Remove static count(), delete() and deleteAll() methods from YqlStatement #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavrukov
force-pushed
the
table-refactoring-rem-count-del
branch
from
05b48e8 to
aae8add
Compare
nvamelichev
changed the title
nvamelichev
requested changes
Dec 4, 2024
| @@ -76,6 +76,16 @@ public static void setUseLegacyRel(boolean value) { | |||
| YqlPredicate.useLegacyRel.set(value); | |||
| } | |||
|
|
|||
| public static YqlPredicate from(Collection<? extends YqlStatementPart<?>> parts) { | |||
| YqlPredicate predicate = YqlPredicate.alwaysTrue(); | |||
There was a problem hiding this comment.
This method will generate a bit better YQL code if you use YqlPredicate.and(Collection<YqlPredicate>) on a collection of parts that are instanceof YqlPredicate, instead instead of turning the YqlStatement.predicateFrom()'s Stream::reduce into a for loop. (The YqlPredicate.and() method also returns YqlPredicate.alwaysTrue() if the predicate collection is empty, so all the invariants of previous implementations would be satisfied, I think.)
lavrukov
force-pushed
the
table-refactoring-rem-find-in
branch
from
b11a0fa to
b21b4bd
Compare
lavrukov
force-pushed
the
table-refactoring-rem-count-del
branch
from
aae8add to
466bcf7
Compare
lavrukov
force-pushed
the
table-refactoring-rem-count-del
branch
from
466bcf7 to
50518bb
Compare
nvamelichev
approved these changes
Dec 4, 2024
nvamelichev
pushed a commit
that referenced
this pull request
Dec 6, 2024
…ment (#104) Co-authored-by: Alexander Lavrukov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.