Remove static findIn() method from YqlStatement #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavrukov
changed the title
lavrukov
force-pushed
the
table-refactoring-rem-find-in
branch
from
fc72a23 to
b11a0fa
Compare
nvamelichev
requested changes
Dec 4, 2024
| } | ||
|
|
||
| @Override | ||
| public <V extends View, ID extends Id<T>> List<V> find(Class<V> viewType, Set<ID> ids, @Nullable FilterExpression<T> filter, @Nullable OrderExpression<T> orderBy, @Nullable Integer limit) { | ||
| if (ids.isEmpty()) { | ||
| return List.of(); | ||
| } | ||
| return executor.execute(YqlStatement.findIn(type, viewType, ids, filter, orderBy, limit), ids); | ||
| ViewSchema<V> viewSchema = ViewSchema.of(viewType); |
There was a problem hiding this comment.
minor: style: var viewSchema will look better here, I think
| } | ||
|
|
||
| @Override | ||
| public <V extends View, K> List<V> find(Class<V> viewType, String indexName, Set<K> keys, @Nullable FilterExpression<T> filter, @Nullable OrderExpression<T> orderBy, @Nullable Integer limit) { | ||
| if (keys.isEmpty()) { | ||
| return List.of(); | ||
| } | ||
| return executor.execute(YqlStatement.findIn(type, viewType, indexName, keys, filter, orderBy, limit), keys); | ||
| ViewSchema<V> viewSchema = ViewSchema.of(viewType); |
There was a problem hiding this comment.
minor: style: var viewSchema will look better here, I think
| @@ -416,7 +423,10 @@ public <ID extends Id<T>> List<ID> findIds(Set<ID> partialIds) { | |||
| if (partialIds.isEmpty()) { | |||
| return List.of(); | |||
| } | |||
| return executor.execute(YqlStatement.findIdsIn(type, partialIds, null, defaultOrder(type), null), partialIds); | |||
| OrderExpression<T> order = defaultOrder(type); | |||
There was a problem hiding this comment.
minor: style: var order and var idSchema will look better here, I think
nvamelichev
approved these changes
Dec 4, 2024
lavrukov
force-pushed
the
table-refactoring-rem-find-in
branch
from
b11a0fa to
b21b4bd
Compare
nvamelichev
pushed a commit
that referenced
this pull request
Dec 6, 2024
Co-authored-by: Alexander Lavrukov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.