Feature/add metadata credentials provider #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmel1k
force-pushed
the
feature/add_metadata_credentials_provider
branch
2 times, most recently
from
223097e
to
6deb722
Compare
shmel1k
force-pushed
the
feature/add_metadata_credentials_provider
branch
from
da2e19a
to
d56fdf7
Compare
nmerkulov
approved these changes
Jul 8, 2024
Jorres
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
No tests makes Egor sad. But oh well.
I would expect an e2e test:
- prepare a local process answering on metadata endpoint (the similar idea as in YDB CMS mock, in this repo, but much simpler, only have to answer to one type of request)
- add DEBUG level log that will print received IAM token (of course masked)
- build a binary, launch a binary with IAM flags and check app logs for mocked token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented authentication via IAM Metadata and IAM ServiceAccount file