refactor(proto)!: proto hierarchy #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark the current proto files as the `v1alpha1` version and move them to the `ydbcp/v1alpha1` directory to match the directory name with the package name.
|
check is failed because GH forbids PR comments from forks. Tests are green |
qrort
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the current proto files as the
v1alpha1version and move them to theydbcp/v1alpha1directory to match the directory name with the package name.This is necessary in order to better support code generation via Bazel's
rules_proto.It is also a common practice (see https://buf.build/docs/lint/rules#package_directory_match).