Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YDB: fix request hanging due to invalid credentials #213

Merged
merged 1 commit into from
Nov 25, 2024
Merged

YDB: fix request hanging due to invalid credentials #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ require (
github.com/spf13/pflag v1.0.5
github.com/stretchr/testify v1.8.4
github.com/wI2L/jsondiff v0.4.0
github.com/ydb-platform/ydb-go-genproto v0.0.0-20241022174402-dd276c7f197b
github.com/ydb-platform/ydb-go-sdk/v3 v3.92.1
github.com/ydb-platform/ydb-go-genproto v0.0.0-20241112172322-ea1f63298f77
github.com/ydb-platform/ydb-go-sdk/v3 v3.92.5
go.uber.org/atomic v1.11.0
go.uber.org/zap v1.26.0
golang.org/x/exp v0.0.0-20240222234643-814bf88cf225
Expand Down
8 changes: 4 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,10 +264,10 @@ github.com/wI2L/jsondiff v0.4.0/go.mod h1:nR/vyy1efuDeAtMwc3AF6nZf/2LD1ID8GTyyJ+
github.com/xdg-go/pbkdf2 v1.0.0/go.mod h1:jrpuAogTd400dnrH08LKmI/xc1MbPOebTwRqcT5RDeI=
github.com/xdg-go/scram v1.1.1/go.mod h1:RaEWvsqvNKKvBPvcKeFjrG2cJqOkHTiyTpzz23ni57g=
github.com/xdg-go/stringprep v1.0.3/go.mod h1:W3f5j4i+9rC0kuIEJL0ky1VpHXQU3ocBgklLGvcBnW8=
github.com/ydb-platform/ydb-go-genproto v0.0.0-20241022174402-dd276c7f197b h1:8yiv/W+1xTdifJh1Stkck0gFJjys9kg0/r86Buljuss=
github.com/ydb-platform/ydb-go-genproto v0.0.0-20241022174402-dd276c7f197b/go.mod h1:Er+FePu1dNUieD+XTMDduGpQuCPssK5Q4BjF+IIXJ3I=
github.com/ydb-platform/ydb-go-sdk/v3 v3.92.1 h1:zD1Zap+dxV87FWpwSfNPgr4zv1X7iKFNwjqWZ26CSMA=
github.com/ydb-platform/ydb-go-sdk/v3 v3.92.1/go.mod h1:ah+n4KaEcANFM+CBKnJ5VrmR0IvWfYFvkofW/56076c=
github.com/ydb-platform/ydb-go-genproto v0.0.0-20241112172322-ea1f63298f77 h1:LY6cI8cP4B9rrpTleZk95+08kl2gF4rixG7+V/dwL6Q=
github.com/ydb-platform/ydb-go-genproto v0.0.0-20241112172322-ea1f63298f77/go.mod h1:Er+FePu1dNUieD+XTMDduGpQuCPssK5Q4BjF+IIXJ3I=
github.com/ydb-platform/ydb-go-sdk/v3 v3.92.5 h1:OlJ1yPyg5svbiUl9+kjckliS5lNY9CVAwT+tOzj0I+Y=
github.com/ydb-platform/ydb-go-sdk/v3 v3.92.5/go.mod h1:WiezFS4YCi2vHqbYGQkeu/2MDBYFLix6dIs/pd87Yck=
github.com/youmark/pkcs8 v0.0.0-20181117223130-1be2e3e5546d/go.mod h1:rHwXgn7JulP+udvsHwJoVG1YGAP6VLg4y9I5dyZdqmA=
github.com/yuin/goldmark v1.1.27/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
github.com/yuin/goldmark v1.2.1/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
Expand Down
8 changes: 0 additions & 8 deletions tests/infra/datasource/ydb/suite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,20 +364,12 @@ func (s *Suite) TestMissingDataSource() {
}

func (s *Suite) TestInvalidLogin() {
if s.connectorMode == config.TYdbConfig_MODE_QUERY_SERVICE_NATIVE {
s.T().Skip("Skipping test in QUERY_SERVICE_NATIVE mode")
}

for _, dsi := range s.dataSource.Instances {
suite.TestInvalidLogin(s.Base, dsi, tables["simple"])
}
}

func (s *Suite) TestInvalidPassword() {
if s.connectorMode == config.TYdbConfig_MODE_QUERY_SERVICE_NATIVE {
s.T().Skip("Skipping test in QUERY_SERVICE_NATIVE mode")
}

for _, dsi := range s.dataSource.Instances {
suite.TestInvalidPassword(s.Base, dsi, tables["simple"])
}
Expand Down
2 changes: 1 addition & 1 deletion tools/ydb/query_service_negative/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func run(endpoint, login, password string) {
log.Fatal(err)
}

log.Printf("Table description: %+v", desc)
log.Printf("Table description: %+v\n", desc)

err = getData(ctx, ydbDriver)
if err != nil {
Expand Down
Loading