Skip to content

Commit

Permalink
Fix typos and add a few suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
fatosmorina committed Nov 28, 2017
1 parent 076d162 commit 37cf9b3
Show file tree
Hide file tree
Showing 13 changed files with 41 additions and 27 deletions.
2 changes: 1 addition & 1 deletion actioncable/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ API documentation is at:

* http://api.rubyonrails.org

Bug reports can be filed for the Ruby on Rails project here:
Bug reports for the Ruby on Rails project can be filed here:

* https://github.com/rails/rails/issues

Expand Down
4 changes: 2 additions & 2 deletions actionmailer/README.rdoc
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ The latest version of Action Mailer can be installed with RubyGems:

$ gem install actionmailer

Source code can be downloaded as part of the Rails project on GitHub
Source code can be downloaded as part of the Rails project on GitHub:

* https://github.com/rails/rails/tree/master/actionmailer

Expand All @@ -166,7 +166,7 @@ API documentation is at

* http://api.rubyonrails.org

Bug reports can be filed for the Ruby on Rails project here:
Bug reports for the Ruby on Rails project can be filed here:

* https://github.com/rails/rails/issues

Expand Down
6 changes: 3 additions & 3 deletions actionpack/README.rdoc
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ The latest version of Action Pack can be installed with RubyGems:

$ gem install actionpack

Source code can be downloaded as part of the Rails project on GitHub
Source code can be downloaded as part of the Rails project on GitHub:

* https://github.com/rails/rails/tree/master/actionpack

Expand All @@ -44,11 +44,11 @@ Action Pack is released under the MIT license:

== Support

API documentation is at
API documentation is at:

* http://api.rubyonrails.org

Bug reports can be filed for the Ruby on Rails project here:
Bug reports for the Ruby on Rails project can be filed here:

* https://github.com/rails/rails/issues

Expand Down
4 changes: 2 additions & 2 deletions actionview/README.rdoc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ The latest version of Action View can be installed with RubyGems:

$ gem install actionview

Source code can be downloaded as part of the Rails project on GitHub
Source code can be downloaded as part of the Rails project on GitHub:

* https://github.com/rails/rails/tree/master/actionview

Expand All @@ -29,7 +29,7 @@ API documentation is at

* http://api.rubyonrails.org

Bug reports can be filed for the Ruby on Rails project here:
Bug reports for the Ruby on Rails project can be filed here:

* https://github.com/rails/rails/issues

Expand Down
9 changes: 5 additions & 4 deletions actionview/RUNNING_UJS_TESTS.rdoc
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
== Running UJS tests

Ensure that you can build the project and run tests.
Run rake ujs:server first, and then run the web tests by
visiting http://localhost:4567 in your browser.
Ensure that you can build the project by running:
rake ujs:server

rake ujs:server
Then run the web tests by visiting the following URL in your browser:

http://localhost:4567
13 changes: 6 additions & 7 deletions actionview/RUNNING_UNIT_TESTS.rdoc
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

The easiest way to run the unit tests is through Rake. The default task runs
the entire test suite for all classes. For more information, checkout the
full array of rake tasks with "rake -T"
full array of rake tasks with <tt>rake -T</tt>

Rake can be found at https://ruby.github.io/rake/.

== Running by hand

To run a single test suite
Run a single test suite:

rake test TEST=path/to/test.rb

Expand All @@ -18,10 +18,9 @@ which can be further narrowed down to one test:

== Dependency on Active Record and database setup

Test cases in the test/activerecord/ directory depend on having
activerecord and sqlite3 installed. If Active Record is not in
actionview/../activerecord directory, or the sqlite3 rubygem is not installed,
these tests are skipped.

Test cases in the +test/activerecord/+ directory depend on having
activerecord+ and +sqlite3+ installed. If Active Record is not in
actionview/../activerecord+ directory, or the +sqlite3+ Ruby gem is not installed,
these tests are skipped.
Other tests are runnable from a fresh copy of actionview without any configuration.

4 changes: 2 additions & 2 deletions activejob/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ The latest version of Active Job can be installed with RubyGems:
$ gem install activejob
```

Source code can be downloaded as part of the Rails project on GitHub
Source code can be downloaded as part of the Rails project on GitHub:

* https://github.com/rails/rails/tree/master/activejob

Expand All @@ -117,7 +117,7 @@ API documentation is at:

* http://api.rubyonrails.org

Bug reports can be filed for the Ruby on Rails project here:
Bug reports for the Ruby on Rails project can be filed here:

* https://github.com/rails/rails/issues

Expand Down
4 changes: 2 additions & 2 deletions activemodel/README.rdoc
Original file line number Diff line number Diff line change
Expand Up @@ -251,11 +251,11 @@ Active Model is released under the MIT license:

== Support

API documentation is at
API documentation is at:

* http://api.rubyonrails.org

Bug reports can be filed for the Ruby on Rails project here:
Bug reports for the Ruby on Rails project can be filed here:

* https://github.com/rails/rails/issues

Expand Down
2 changes: 1 addition & 1 deletion activerecord/README.rdoc
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ API documentation is at:

* http://api.rubyonrails.org

Bug reports can be filed for the Ruby on Rails project here:
Bug reports for the Ruby on Rails project can be filed here:

* https://github.com/rails/rails/issues

Expand Down
14 changes: 14 additions & 0 deletions activestorage/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,3 +143,17 @@ Active Storage, with its included JavaScript library, supports uploading directl
## License
Active Storage is released under the [MIT License](https://opensource.org/licenses/MIT).
## Support
API documentation is at:
* http://api.rubyonrails.org
Bug reports for the Ruby on Rails project can be filed here:
* https://github.com/rails/rails/issues
Feature requests should be discussed on the rails-core mailing list here:
* https://groups.google.com/forum/?fromgroups#!forum/rubyonrails-core
2 changes: 1 addition & 1 deletion activesupport/README.rdoc
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ API documentation is at:

* http://api.rubyonrails.org

Bug reports can be filed for the Ruby on Rails project here:
Bug reports for the Ruby on Rails project can be filed here:

* https://github.com/rails/rails/issues

Expand Down
2 changes: 1 addition & 1 deletion ci/travis.rb
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def env
if activesupport? && !isolated?
# There is a known issue with the listen tests that causes files to be
# incorrectly GC'ed even when they are still in-use. The current solution
# is to only run them in isolation to avoid randomly failing our test suite.
# is to only run them in isolation to avoid random failures of our test suite.
{ "LISTEN" => "0" }
else
{}
Expand Down
2 changes: 1 addition & 1 deletion guides/rails_guides/markdown/renderer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def convert_notes(body)
#
# It is important that we do not eat more than one newline
# because formatting may be wrong otherwise. For example,
# if a bulleted list follows the first item is not rendered
# if a bulleted list follows, the first item is not rendered
# as a list item, but as a paragraph starting with a plain
# asterisk.
body.gsub(/^(TIP|IMPORTANT|CAUTION|WARNING|NOTE|INFO|TODO)[.:](.*?)(\n(?=\n)|\Z)/m) do
Expand Down

0 comments on commit 37cf9b3

Please sign in to comment.