Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't close file descriptors in .target.bash calls (bsc#1218064) #166

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Don't close file descriptors in .target.bash calls (bsc#1218064) #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96ca426
Don't close file descriptors in .target.bash calls (bsc#1218064)
mvidner Jan 8, 2024
631dd45
version + changelog
mvidner Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions agent-system/src/ShellCommand.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,10 @@ shellcommand ( const string &target_root, const string &command, const string &t

// #223602
// close all file descriptors above stderr
for ( int i = getdtablesize() - 1; i > 2; --i ) {
close( i );
}
//
// But Ruby uses some for thread communications,
// bsc#1218064, so don't.
// Systemd daemon handling has meanwhile solved the original bug.

// we want to work on different target root
if (target_root != "/")
Expand Down
8 changes: 8 additions & 0 deletions package/yast2-core.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
-------------------------------------------------------------------
Wed Jan 10 16:22:03 UTC 2024 - Martin Vidner <[email protected]>

- Don't close file descriptors in .target.bash calls (bsc#1218064)
avoiding "[ASYNC BUG] rb_thread_wakeup_timer_thread: write(3) EBADF"
with Ruby 3.3
- 5.0.2

-------------------------------------------------------------------
Tue Nov 28 13:24:23 UTC 2023 - Stefan Hundhammer <[email protected]>

Expand Down
2 changes: 1 addition & 1 deletion package/yast2-core.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
%bcond_with werror

Name: yast2-core
Version: 5.0.1
Version: 5.0.2
Release: 0
Url: https://github.com/yast/yast-core

Expand Down
Loading