add new model named credit card estimator used to detect whether the … #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transaction is faulty or not by randomforestcalssifier
yashasvini121
requested changes
Oct 10, 2024
|
Please mention the relevant issue no. as well |
|
This PR addresses the issue #2 |
yashasvini121
requested changes
Oct 10, 2024
There was a problem hiding this comment.
- Model_details function is missing from your code.
- After testing various combinations of inputs, the model consistently returns "Fraud" as the output.
- Please provide a proper model_details function that outputs key evaluation parameters of the RandomForestClassifier. Like: Accuracy, Precision, Recall, F1 Score, Confusion Matrix, Feature Importance etc.
This would help in understanding the performance and behavior of the model more clearly. - Additionally, I noticed the notebook is missing. While it’s not important, if you’ve tried other models, it would be great to showcase that work as well.
… add model_details function and plot some graphs
…it-card-estimator
|
Please check the new commits. Try to resolve all the problem |
|
Is there any issue still needs to work on? |
yashasvini121
approved these changes
Oct 27, 2024
yashasvini121
added
hacktoberfest-accepted
gssoc-ext
level2
and removed
changes-requested
labels
|
OK so please close this pr now
…On Sun, 27 Oct, 2024, 9:44 pm Yashasvini Sharma, ***@***.***> wrote:
Merged #113 <#113>
into master.
—
Reply to this email directly, view it on GitHub
<#113 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3BOH4BT25OYI23B6CZZFJ3Z5UGOPAVCNFSM6AAAAABPWNDGRKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUHEZDONRTGYZTAMI>
.
You are receiving this because you were assigned.Message ID:
***@***.***
com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…transaction is faulty or not by randomforestcalssifier
Description
Issue Resolved
Changes Made
Screenshots or Videos
Additional Details
Checklist
requirements.txtfile to include any new packagespredict.pyfile includes a properly implementedmodel_details()function, or the notebook contains this function to print a detailed model report. The model will not be accepted without this function, as it is essential for generating the necessary model details.