Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create stencil for adhesive layers #374

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

create stencil for adhesive layers #374

wants to merge 8 commits into from

Conversation

wannessels
Copy link

  • added --type option for adhesive, defaults to solderpaste
  • changed zipping gerbers from subprocess.check_call("zip") to shutil.make_archive()
  • fixed --cutout (layer names did not match)

yaqwsx
yaqwsx requested changes Sep 15, 2022
View reviewed changes
Copy link
Owner

@yaqwsx yaqwsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry it took me so long to review these changes. I left some of my notes in the comment, and please, let me know what you think.

kikit/stencil_ui.py Outdated Show resolved Hide resolved
kikit/stencil.py Outdated Show resolved Hide resolved
kikit/export.py Outdated Show resolved Hide resolved
kikit/export.py Outdated Show resolved Hide resolved
@wannessels
Copy link
Author

I've made some changes:

  • replaced enum with dataclass & constants
  • reverted formatting change for click options help
  • added typing to all changed methods
  • set stencil_type default to SolderPaste, wherever the parameter was added, for backwards compatibility

@wannessels wannessels force-pushed the stenciltype branch 3 times, most recently from f8ce693 to 222512c Compare September 24, 2022 17:27
Merge remote-tracking branch 'wannes/stenciltype_PR_changes'
015fec7 
# Conflicts:
#	kikit/export.py
#	kikit/fab/oshpark.py
#	kikit/stencil.py
@yaqwsx yaqwsx force-pushed the master branch 5 times, most recently from 63883b3 to e0c897b Compare February 26, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaqwsx yaqwsx yaqwsx requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wannessels @yaqwsx