Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Chinese (Traditional and Simplified) #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kenny2github
Copy link

  • Register zh-TW and zh-CN
  • New language option: joinSeparator allows changing the space between words to something else, like an empty string in Chinese's case.
  • New language option: prependZero implements Chinese style zero insertion

+lib/i18n/zh-*.json:
* Language definition files, using new options
* Differences:
  * A couple characters differ
  * Simplified has no word for trillion (because mainland China)

lib/index.js:
+ Register zh-TW and zh-CN
+ New internal option: smallMeans10. Introduced to resolve issues
  where languages without 20, 30, etc as bases (because they use 10
  as a unit instead) were not getting their "two tens" set properly.
  Should not really be set by user code.
+ New language option: joinSeparator allows changing the space between
  words to something else, like an empty string in Chinese's case.
+ New language option: prependZero implements Chinese style zero
  insertion
* Cleaned up a bit

test/index.test.js:
+ Tests for zh-TW
+ Tests for zh-CN (which end earlier than zh-TW - see comment
  at the end of the changes)

README.md:
+ Documented new language and new language options
* Cleaned up a bit

.gitignore:
+ Some people (like me) develop on Visual Studio or VSCode

bower.json, package.json:
* Bump version to 0.12.0
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 99.254% when pulling bd39718 on Kenny2github:master into fdd8cac on yamadapc:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 99.254% when pulling bd39718 on Kenny2github:master into fdd8cac on yamadapc:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants