Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IYY-266: Updates existing Power BI embeds to work with new Power BI embedder #830

Merged
merged 1 commit into from
Dec 13, 2024
Merged

IYY-266: Updates existing Power BI embeds to work with new Power BI embedder #830

merged 1 commit into from
Dec 13, 2024

Conversation

codechefmarc
Copy link
Contributor

@codechefmarc codechefmarc commented Dec 13, 2024 •
edited
Loading

Description of work

  • Adds an update hook to fix existing Power BI embeds to work with new Power BI code

Functional testing steps:

  • Visit the test site and verify that on the home page no errors exist about Power BI embed
  • Scroll down and verify that the Power BI embed loads

@codechefmarc codechefmarc self-assigned this Dec 13, 2024
@github-actions GitHub Actions
Copy link

Visit Site

Created multidev environment pr-830 for yalesites-platform.

@codechefmarc codechefmarc marked this pull request as ready for review December 13, 2024 01:26
@codechefmarc codechefmarc requested a review from a team as a code owner December 13, 2024 01:26
dblanken-yale
dblanken-yale approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No errors for me locally, even with the same DB. :D

@codechefmarc codechefmarc merged commit 10d451e into develop Dec 13, 2024
3 checks passed
@codechefmarc codechefmarc deleted the IYY-266--power-bi-hotfix branch December 13, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblanken-yale dblanken-yale dblanken-yale approved these changes

Assignees

@codechefmarc codechefmarc

Labels
needs review pass code review pass functional review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codechefmarc @dblanken-yale