Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only run release_pr.yml workflow against release branch pattern, not master #818

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

vinmassaro
Copy link
Contributor

Description of work

The release_pr.yml workflow is triggered manually using workflow_dispatch, and on pull request synchronize/closed activities. It is running unexpectedly against other pull requests to master, like hotfixes. Since it currently does not need to run automatically against pull requests to master since we create release PRs using workflow_dispatch, this change sets it to only run on pull requests matching the release branch naming pattern.

The release_pr.yml workflow is triggered manually using workflow_dispatch, and on pull request synchronize/closed activities. It is running unexpectedly against other pull requests to master, like hotfixes. Since it currently does not need to run automatically against pull requests to master since we create release PRs using workflow_dispatch, this change sets it to only run on pull requests matching the release branch naming pattern.
@vinmassaro vinmassaro requested a review from a team as a code owner December 3, 2024 19:23
@vinmassaro vinmassaro merged commit 3d0069b into develop Dec 3, 2024
3 checks passed
@vinmassaro vinmassaro deleted the ci-release-pr-fix branch December 3, 2024 19:32
@yalesites yalesites mentioned this pull request Dec 3, 2024
@yalesites yalesites mentioned this pull request Dec 12, 2024
@yalesites
Copy link

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants