fix: remove duplicative dependencies from require-dev stanza #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are running into an issue where slevomat/coding-standard is being installed from the master branch of that project, instead of the 8.x version as defined. The root cause is hard to track down, but stripping down the require-dev stanza fixes the issue.
dblanken-yale
approved these changes
Dec 2, 2024
|
Created multidev environment pr-817 for yalesites-platform. |
Closed
Merged
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
We are running into an issue where
slevomat/coding-standard:dev-masteris being installed instead of the 8.15.0 release version as defined. The root cause is hard to track down, but stripping down ourrequire-devstanza in root composer.json to just containdrupal/core-devfixes the issue.All dependencies being removed are installed as part of
drupal/core-dev, except for the below packages, which we are not using:drupal/drupal-driverdrupal/drupal-extensionFunctional testing steps:
slevomat/coding-standard:8.15.0is installed, notdev-master