Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IYY-282: Site Editors can add a simple outlined callout #812

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

codechefmarc
Copy link
Contributor

@codechefmarc codechefmarc commented Nov 27, 2024

IYY-282: Site Editors can add a simple outlined callout

Description of work

  • Adds a new block type of Wrapped Text Callout
  • Atomic PR wires up the new component
  • Prior to merge, we are awaiting a preview image from Mike Tullo
  • Requires Atomic PR-287 and Component Library Twig PR-436
  • Also fixes focal point by updating to latest version to prevent Ajax error and allow patch to continue to be applied

Functional testing steps:

  • Login to the site
  • Add a new page, post, or event or edit an existing one
  • Enter layout builder
  • Click Add Block
  • Verify there is a new block "Wrapped Text Callout" (Image to come before merge)
  • Click on the title to add
  • Verify there are the new fields for Callout, Content, Callout Position, and Theme

Screenshot 2024-11-27 at 9 36 10 AM

  • Fill out the fields and save the block
  • Verify that the block gets the styling from the component library

Screenshot 2024-11-27 at 9 39 30 AM

  • Test out the controls for position and theme and verify that they work as expected
  • Remove the text in the Content field and verify that the callout goes full width

Screenshot 2024-11-27 at 9 39 04 AM

@codechefmarc codechefmarc changed the title IYY-282): Add config for new wrapped callout block IYY-282): Site Editors can add a simple outlined callout Nov 27, 2024
@codechefmarc codechefmarc self-assigned this Nov 27, 2024
Copy link

Visit Site

Created multidev environment pr-812 for yalesites-platform.

@codechefmarc codechefmarc changed the title IYY-282): Site Editors can add a simple outlined callout IYY-282: Site Editors can add a simple outlined callout Nov 27, 2024
@codechefmarc codechefmarc marked this pull request as ready for review November 27, 2024 17:42
@codechefmarc codechefmarc requested a review from a team as a code owner November 27, 2024 17:42
Copy link
Contributor

@joetower joetower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codechefmarc Looks great! 🥳

Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm noticing when in layout builder the callout is expanding past the block bounds. Do you all see this as well? I'm in Safari. It functions very well other than that. :(

Screenshot 2024-12-02 at 8 58 20 AM Screenshot 2024-12-02 at 8 59 18 AM Screenshot 2024-12-02 at 9 01 56 AM

@miketullo95
Copy link
Contributor

miketullo95 commented Dec 2, 2024

@codechefmarc here is the picker icon!
wrapped callout

Also, was there a business requirement from IYY to have the option to not have content and have the callout be flexible? I think it looks great, but the name 'Wrapped Callout' may not make sense with this flexibility. If there is not a reason, my suggestion would be to make 'Content' required. Let me know!

Some small AX changes:

  • Change callout field label to "Callout Content"
  • Change content field label to "Wrapped Content"

@codechefmarc codechefmarc changed the base branch from develop to iyy-sprint-03 December 5, 2024 23:36
@codechefmarc
Copy link
Contributor Author

codechefmarc commented Dec 6, 2024

@miketullo95 - Added the new preview image (thank you!) and changed the field labels.

@dblanken-yale - I also had to update focal point to the latest version because composer wasn't installing properly, so this fixes an Ajax issue as well as allows the patch to be applied. Note too, this is our first PR that will not merge directly into develop, but instead into iyy-sprint-03. We'll have to work to figure out the best way to merge these into either develop or some sort of final IYY branch that we can use for full testing ahead of merging with the rest of the platform. The changes that will go this route are the larger changes we don't want to release just yet.

@codechefmarc codechefmarc merged commit 444e9c1 into iyy-sprint-03 Dec 11, 2024
3 checks passed
@codechefmarc codechefmarc deleted the IYY-282-wrapped-callout branch December 11, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants