-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IYY-282: Site Editors can add a simple outlined callout #812
Conversation
Created multidev environment pr-812 for yalesites-platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codechefmarc Looks great! 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codechefmarc here is the picker icon! Also, was there a business requirement from IYY to have the option to not have content and have the callout be flexible? I think it looks great, but the name 'Wrapped Callout' may not make sense with this flexibility. If there is not a reason, my suggestion would be to make 'Content' required. Let me know! Some small AX changes:
|
@miketullo95 - Added the new preview image (thank you!) and changed the field labels. @dblanken-yale - I also had to update focal point to the latest version because composer wasn't installing properly, so this fixes an Ajax issue as well as allows the patch to be applied. Note too, this is our first PR that will not merge directly into |
IYY-282: Site Editors can add a simple outlined callout
Description of work
Functional testing steps: