Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IYY-266: Ensure Microsoft BI embeds work #810

Merged
merged 6 commits into from
Dec 11, 2024
Merged

IYY-266: Ensure Microsoft BI embeds work #810

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
09a9563
feat(IYY-266): Relax Power BI embed to allow for both /view and /repo…
codechefmarc Nov 26, 2024
6b83814
feat(IYY-266): Change Power BI embed to allow two kinds of URLs - vie…
codechefmarc Nov 26, 2024
9459795
Merge branch 'develop' into IYY-266--fix-ms-bi-embed
codechefmarc Nov 26, 2024
2ac989a
Merge branch 'develop' into IYY-266--fix-ms-bi-embed
codechefmarc Dec 5, 2024
8118abb
feat(IYY-266): Update instructions and examples for Power BI to get b…
codechefmarc Dec 5, 2024
7113ee3
fix(IYY-266): Change public example back to original example
codechefmarc Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ...files/custom/yalesites_profile/modules/custom/ys_embed/src/Plugin/EmbedSource/PowerBI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ class PowerBI extends EmbedSourceBase implements EmbedSourceInterface {
/**
* {@inheritdoc}
*/
protected static $pattern = '/^https:\/\/app.powerbi.com\/view(?<form_params>.+)/';
protected static $pattern = '/^https:\/\/app.powerbi.com\/(?<type>view|reportEmbed)(?<query_params>\?.+)/';

/**
* {@inheritdoc}
*/
protected static $template = '<iframe class="iframe" title="{{ title }}" src="https://app.powerbi.com/view{{ form_params }}" height="100%" width="100%" loading="lazy"></iframe>';
protected static $template = '<iframe class="iframe" title="{{ title }}" src="https://app.powerbi.com/{{ type }}{{ query_params }}" height="100%" width="100%" loading="lazy"></iframe>';

/**
* {@inheritdoc}
Expand All @@ -36,7 +36,7 @@ class PowerBI extends EmbedSourceBase implements EmbedSourceInterface {
/**
* {@inheritdoc}
*/
protected static $example = 'https://app.powerbi.com/view?r=eyJrIjoiYzQ1ODA0ZjEtZjc5YS00OTgyLWIzOTItNmJmNDY2YmRiODQ2IiwidCI6ImRkOGNiZWJiLTIxMzktNGRmOC1iNDExLTRlM2U4N2FiZWI1YyIsImMiOjF9&pageName=ReportSection2ac2649f17189885d376';
protected static $example = 'https://app.powerbi.com/reportEmbed?reportId=66e25bd6-5e0a-4db8-ad0c-28bb31b0fd5e&autoAuth=true&ctid=dd8cbebb-2139-4df8-b411-4e3e87abeb5c';

/**
* {@inheritdoc}
Expand All @@ -54,8 +54,9 @@ class PowerBI extends EmbedSourceBase implements EmbedSourceInterface {
* {@inheritdoc}
*/
public function getUrl(array $params): string {
$form_params = $params['form_params'];
return 'https://app.powerbi.com/view' . $form_params;
$type = $params['type'];
$query_params = $params['query_params'];
return 'https://app.powerbi.com/' . $type . $query_params;
}

}