docs(git): document about making atomic a safe directory #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, vendors were receiving strange errors related to the atomic directory already existing. It turned out the real issue was that git detected strange ownership of it, and would disallow it from being brought down. While the first fix is to ensure that yalesites-org/* was marked in composer as prefer-dist in the config.json, the next is to add a safe directory to allow this to work again.
|
Created multidev environment pr-795 for yalesites-platform. |
codechefmarc
requested changes
Nov 15, 2024
There was a problem hiding this comment.
The command I had to run was:
git config --global --add safe.directory /app/web/themes/contrib/atomic
with the "app" specified because it was inside a container - I don't know how this would be different if not run from within Docker - i.e. a separate AMP stack - but I think changing it to that makes sense because this repo is setup to use Lando.
|
Gotcha; updated the command so it includes app. Good that I added you! haha |
vinmassaro
approved these changes
Nov 18, 2024
Merged
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs(git): speak about making atomic a safe directory
In some cases, vendors were receiving strange errors related to the atomic directory already existing. It turned out the real issue was that git detected strange ownership of it, and would disallow it from being brought down.
While the first fix is to ensure that yalesites-org/* was marked in composer as prefer-dist in the config.json, the next is to add a safe directory to allow this to work again.
Description of work