Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YSP-650: Allow multiple Affiliation/Profile terms to be auto completed like tags #767

Closed
wants to merge 2 commits into from
Closed

YSP-650: Allow multiple Affiliation/Profile terms to be auto completed like tags #767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
998067e
feat(YSP-351): allow multiple affiliations with chosen
dblanken-yale Sep 23, 2024
7bb2e11
chore(YSP-650): fix linting issues
dblanken-yale Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...es/custom/yalesites_profile/config/sync/core.entity_form_display.node.profile.default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ content:
placeholder: ''
third_party_settings: { }
field_affiliation:
type: options_select
type: chosen_select
weight: 36
region: content
settings: { }
Expand Down
2 changes: 1 addition & 1 deletion web/profiles/custom/yalesites_profile/config/sync/field.storage.node.field_affiliation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ settings:
target_type: taxonomy_term
module: core
locked: false
cardinality: 1
cardinality: -1
translatable: true
indexes: { }
persist_with_no_fields: false
Expand Down
2 changes: 1 addition & 1 deletion ...es/custom/yalesites_profile/modules/custom/ys_core/src/Plugin/Action/ModeratedPublish.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public function execute($entity = NULL) {
/**
* {@inheritdoc}
*/
public function access($object, AccountInterface $account = NULL, $return_as_object = FALSE) {
public function access($object, ?AccountInterface $account = NULL, $return_as_object = FALSE) {
$key = $object->getEntityType()->getKey('published');

/** @var \Drupal\Core\Entity\EntityInterface $object */
Expand Down
2 changes: 1 addition & 1 deletion .../custom/yalesites_profile/modules/custom/ys_core/src/Plugin/Action/ModeratedUnpublish.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public function execute($entity = NULL) {
/**
* {@inheritdoc}
*/
public function access($object, AccountInterface $account = NULL, $return_as_object = FALSE) {
public function access($object, ?AccountInterface $account = NULL, $return_as_object = FALSE) {
$key = $object->getEntityType()->getKey('published');

/** @var \Drupal\Core\Entity\EntityInterface $object */
Expand Down
2 changes: 1 addition & 1 deletion ...profiles/custom/yalesites_profile/modules/custom/ys_layouts/src/Service/LayoutUpdater.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

namespace Drupal\ys_layouts\Service;

use Drupal\block_content\Entity\BlockContent;
use Drupal\Core\Config\ConfigFactoryInterface;
use Drupal\Core\Database\Connection;
use Drupal\Core\Entity\EntityFieldManager;
use Drupal\Core\Entity\EntityStorageException;
use Drupal\Core\Entity\EntityTypeManagerInterface;
use Drupal\Core\Messenger\MessengerInterface;
use Drupal\Core\StringTranslation\StringTranslationTrait;
use Drupal\block_content\Entity\BlockContent;
use Drupal\node\NodeInterface;
use Psr\Log\LoggerInterface;

Expand Down
2 changes: 1 addition & 1 deletion web/profiles/custom/yalesites_profile/modules/custom/ys_localist/src/MetaFieldsManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

namespace Drupal\ys_localist;

use Drupal\calendar_link\Twig\CalendarLinkTwigExtension;
use Drupal\Core\Datetime\DateFormatter;
use Drupal\Core\Entity\EntityTypeManager;
use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
use Drupal\Core\Url;
use Drupal\calendar_link\Twig\CalendarLinkTwigExtension;
use Drupal\node\NodeInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;

Expand Down
2 changes: 1 addition & 1 deletion ...s_profile/modules/custom/ys_localist/src/Plugin/migrate_plus/data_parser/LocalistJson.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ protected function getSourceData(string $url): array {
// If json_decode() has returned NULL, it might be that the data isn't
// valid utf8 see http://php.net/manual/en/function.json-decode.php#86997.
if (is_null($source_data)) {
$utf8response = utf8_encode($response);
$utf8response = mb_convert_encoding($response, 'UTF-8', 'ISO-8859-1');
$source_data = json_decode($utf8response, TRUE, 512, JSON_THROW_ON_ERROR);
}

Expand Down
2 changes: 1 addition & 1 deletion web/profiles/custom/yalesites_profile/modules/custom/ys_themes/ys_themes.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ use Drupal\field\Entity\FieldStorageConfig;
*
* @see options_allowed_values()
*/
function ys_themes_allowed_values_function(FieldStorageConfig $definition, ContentEntityInterface $entity = NULL, $cacheable) {
function ys_themes_allowed_values_function(FieldStorageConfig $definition, ?ContentEntityInterface $entity = NULL, $cacheable) {
$options = [];
$config = \Drupal::config('ys_themes.component_overrides');

Expand Down
2 changes: 1 addition & 1 deletion ...alesites_profile/modules/custom/ys_views_basic/src/Plugin/views/filter/PostYearFilter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public static function create(ContainerInterface $container, array $configuratio
/**
* {@inheritdoc}
*/
public function init(ViewExecutable $view, DisplayPluginBase $display, array &$options = NULL) {
public function init(ViewExecutable $view, DisplayPluginBase $display, ?array &$options = NULL) {
parent::init($view, $display, $options);

$this->valueTitle = $this->t('Post Year Filter');
Expand Down