Hotfix v1.8.0: Views thumbnail fix -- MULTIDEV ONLY #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an existing view is modified, the default was that show thumbnail would be false, when in fact, it should default to true. When creating new views, it does this, but for those that had no value at all, it defaulted to unchecked. This checks if fieldOptionValue is empty and if so, it uses the default value of show_thumbnail enabled.
There are three states we're targeting here:
1. A new view where the default should be that show_thumbnail is on
2. A previously saved view where they might have enabled or disabled
show_thumbnail
3. An existing view that was there before these options were
presented (no config options set)
We want to make sure that the default behavior is that where appropriate
cards display thumbnails by default until they opt out. This attempt to
determine if there's no config at all (existing view before update) and
sets the thumbnail option accordingly.
|
This is only for a multidev |
dblanken-yale
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YALB-XX: Title
Description of work
Functional testing steps: