Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YSP-670: Spotlights provide H2 in Banner Section #754

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

dblanken-yale
Copy link
Contributor

@dblanken-yale dblanken-yale commented Sep 12, 2024

YSP-670: Spotlights provide H2 in Banner Section

Description of work

  • Adds Heading level to portrait and landscape spotlights now that they are in the banner options
  • Wiring done also in Atomic and Component Library Twig -- please review these as well

Functional testing steps:

  • Create a spotlight in the banner
  • Set the title to be either visibly hidden or hidden
  • Modify your spotlight to use a heading level of H1
  • Verify it renders correctly with an H1
  • Verify that the first spotlight's top-margin is set to 2rem
  • Verify that other spotlights added that aren't at the top are not set to 2rem
  • Ensure that other banner blocks placed at the top do not exhibit this spacing
  • Ensure that spotlights added to a banner whose first block was not a spotlight spaces as expected

@dblanken-yale dblanken-yale self-assigned this Sep 12, 2024
@dblanken-yale dblanken-yale marked this pull request as ready for review September 12, 2024 15:28
@dblanken-yale dblanken-yale requested a review from a team as a code owner September 12, 2024 15:28
Copy link

Visit Site

Created multidev environment pr-754 for yalesites-platform.

Copy link

@kara-franco kara-franco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!! Yay, this is a good fix for this release.

@dblanken-yale dblanken-yale merged commit 89c0db8 into develop Sep 13, 2024
3 checks passed
This was referenced Sep 17, 2024
@yalesites
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants