Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YSP-301: Card collections without images #600

Closed

Conversation

laura-johnson
Copy link
Contributor

@laura-johnson laura-johnson commented Mar 12, 2024

YSP-301: Card collections without images

Description of work

  • Adds text_card view mode for content
  • Adds config for text_card on all content types
  • Adds text_card to the views tool

Functional testing steps:

  • All variations of the text card have been added to a test page for demo and review. Please make sure the rendered content in Drupal matches the styles in the Yale Design System.
  • Edit any page layout to see these new features in action
  • Add a new 'view' and note that a new 'Text Card' option exists. The previous 'Card' display has been renamed 'Visual Card'. These exist for all content type.
  • The new text card display has an icon
  • Verify that adding a Text Card for any content type results in a card identical to Visual Card but with no image.

I set up a demo here: https://pr-600-yalesites-platform.pantheonsite.io/text-card-demo

Here is the related Atomic PR with templates: yalesites-org/atomic#210

Screenshot of the new controls:
Screenshot 2024-09-20 at 10 41 07 AM

Screenshot of all text card options:
pr-600-yalesites-platform pantheonsite io_text-card-demo

Copy link

Visit Site

Created multidev environment pr-600 for yalesites-platform.

Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Tested a few different modes wit the views tool and compared to custom cards as well. I'd like @kara-franco to review as well as she was the original reporter.

@kara-franco
Copy link

Amazing!! Approved on my end both for a11y and completion of ticket!

@nJim nJim requested a review from a team March 22, 2024 14:47
nJim

This comment was marked as outdated.

@nJim
Copy link
Contributor

nJim commented Apr 11, 2024

We will discuss the frontend needs in today's standup part 2.

@nJim
Copy link
Contributor

nJim commented May 28, 2024

@kara-franco Will help identify treatments for content without an image.

Copy link

Visit Site

Created multidev environment pr-600 for yalesites-platform.

@nJim nJim changed the title feat: ysp-301 add text_card view mode to content types and views tool YSP-301: Card collections without images Sep 20, 2024
@dblanken-yale
Copy link
Contributor

Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants