-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YALB-1303: Finding content tagged with a specific tag #421
Conversation
…iliation to management views
Created multidev environment pr-421 for yalesites-platform. |
I went through all functioning testing steps and everything works as expected for me. Thank you. For the exposed filters on "Tags" and "Categories", is it possible to have the exposed filter to be typed into (i.e. typing "admin" into the search bar) and also be a dropdown? I'm not sure if that's worth it, but I'm thinking of the potential extreme case where someone might know what's available to them. |
@jvaughn-johnson - I've added Chosen to the exposed filters. Note the threshold for it to be enabled is 15 items or more, so if the list has less than 15, it's a simple dropdown select. After 15, you'll get both an autocomplete with dropdown. Let me know if this works for you. |
@codechefmarc Unrelated to this PR, just wanted to throw it out there since you're in "Chosen" mode and I noticed it while testing this. 😁 I noticed that in the create profile contact info, the tags field is not using chosen, but instead is using the drupal select. Didn't know if you wanted to incorporate the fix in this or wait for a new ticket, but my worry is we'd run into a backward compatibility problem if we don't address it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally works great! I love seeing this as part of the views. Great work!
@dblanken-yale - good call, that is easy to add to profiles so I'll do that and let you know when finished. |
@codechefmarc Awesome; will be easy to test with this PR I think as I've already created the profile. We can see what it will do and then test a new one. Just ping me and I'll test. :D |
@dblanken-yale - OK, you're good to go - Profiles tagging is Chosen enabled! |
@codechefmarc Just verifying; did you happen to add "generic" as a tag to Davy Jones? I ask because while admin is showing, which is what I had entered, I didn't remember entering "generic" as a term, and of course that's taxonomy id 1, which makes me suspicious. If you did, that makes me feel better. |
The other profile works great, and doesn't have generic so I bet I either added it and forgot or someone else did. I think that looks good now! Good fix! |
😆 Yes, that was me adding it to test. So, not an error! We should ban any taxonomy term with id 1. Hehe. @jvaughn-johnson - would you like to take another look before I merge? Thanks! |
Hi @codechefmarc. Somehow I missed your comment from 5 days ago. The update looks good to me and I think the logic behind when Chosen decides to show both the dropdown and autocomplete makes sense. I think people will appreciate this new feature overall. Thank you. |
YALB-1303: Finding content tagged with a specific tag
Description of work
Functional testing steps:
/admin/content
)/admin/content/manage-pages
)/admin/content/manage-posts
)/admin/content/manage-events
)/admin/content/manage-profiles
)