Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YALB-1462: Bug: Content Spotlight Requires Link #418

Merged

Conversation

dblanken-yale
Copy link
Contributor

@dblanken-yale dblanken-yale commented Sep 11, 2023

YALB-1462: Bug: Content Spotlight Requires Link

Description of work

  • Makes link field for Content Spotlight optional
  • Double checked that no atomic/CL changes were needed

Functional testing steps:

  • Visit PR Multidev
  • On a page, add a content spotlight
  • Leave the link section blank, but fill out any required fields
  • Add the block to the page
  • Verify that there are no remnants of HTML referring to a link in the output
  • Edit the block
  • Add a link
  • Verify that the link exists on the outputted page

As stated in the Jira ticket:

Example: https://yalesites.yale.edu/our-vision-guiding-principles Guiding principles would work very well in cascading Content Spotlights, but the required single CTA link prevents this Block from being used as intended.

A proof of concept for this is using the modified content spotlight is at https://pr-418-yalesites-platform.pantheonsite.io/daves-content-spotlight

@dblanken-yale dblanken-yale self-assigned this Sep 11, 2023
@dblanken-yale dblanken-yale force-pushed the YALB-1462-bug-content-spotlight-requires-link branch from d019c2f to 5c572d1 Compare September 11, 2023 20:09
@dblanken-yale dblanken-yale force-pushed the YALB-1462-bug-content-spotlight-requires-link branch from 5c572d1 to 7b942dd Compare September 12, 2023 13:26
@github-actions
Copy link

Visit Site

Created multidev environment pr-418 for yalesites-platform.

@dblanken-yale dblanken-yale marked this pull request as ready for review September 12, 2023 16:25
Copy link
Contributor

@nJim nJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@dblanken-yale dblanken-yale merged commit 86c8bd3 into develop Sep 12, 2023
3 checks passed
@dblanken-yale dblanken-yale deleted the YALB-1462-bug-content-spotlight-requires-link branch September 12, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants