Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOTFIX: Fix Nodes not able to be viewed if no menu item #414

Merged
merged 1 commit into from
Sep 8, 2023
Merged

HOTFIX: Fix Nodes not able to be viewed if no menu item #414

merged 1 commit into from
Sep 8, 2023

Conversation

codechefmarc
Copy link
Contributor

@codechefmarc codechefmarc commented Sep 8, 2023 •
edited by nJim
Loading

Description of work

  • It was discovered that with some custom code, if a node didn't have a menu item attached and you saved the node, it would mess up the site and prevent nodes (and the menu form) from being viewed and instead give missing route errors.
  • This PR removes the custom code and to edit menu item extras (the heading CTA), content editors need to go into the menu item itself and can't be done on the node form.

Functional testing steps:

  • Edit a node that does not have a link in the main menu
  • Save the node
  • View the node
  • Verify no errors show

@codechefmarc codechefmarc self-assigned this Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Visit Site

Created multidev environment pr-414 for yalesites-platform.

@codechefmarc codechefmarc mentioned this pull request Sep 8, 2023
Merged
11 tasks
nJim
nJim approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@nJim nJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This fixes the issue.

@codechefmarc codechefmarc merged commit 440838f into develop Sep 8, 2023
3 checks passed
@codechefmarc codechefmarc deleted the hotfix-menu-item-extras branch September 8, 2023 17:11
@nJim nJim mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nJim nJim nJim approved these changes

Assignees

@codechefmarc codechefmarc

Labels
pass code review pass functional review ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codechefmarc @nJim