Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YALB-1416: Bug: Empty Headings in HTML | YALB-1312: Bug: Style views Event Time Period radio buttons | YALB-1215: Dials: Banner heading levels #407

Merged
merged 16 commits into from
Sep 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ dependencies:
config:
- block_content.type.cta_banner
- field.field.block_content.cta_banner.field_heading
- field.field.block_content.cta_banner.field_heading_level
- field.field.block_content.cta_banner.field_instructions
- field.field.block_content.cta_banner.field_link
- field.field.block_content.cta_banner.field_media
Expand Down Expand Up @@ -39,6 +40,12 @@ content:
maxlength_js: 50
maxlength_js_label: 'Content limited to @limit characters, remaining: <strong>@remaining</strong>'
maxlength_js_enforce: false
field_heading_level:
type: options_select
weight: 16
region: content
settings: { }
third_party_settings: { }
field_instructions:
type: markup
weight: 0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ dependencies:
config:
- block_content.type.grand_hero
- field.field.block_content.grand_hero.field_heading
- field.field.block_content.grand_hero.field_heading_level
- field.field.block_content.grand_hero.field_instructions
- field.field.block_content.grand_hero.field_link
- field.field.block_content.grand_hero.field_media
Expand Down Expand Up @@ -39,6 +40,12 @@ content:
maxlength_js: 50
maxlength_js_label: 'Content limited to @limit characters, remaining: <strong>@remaining</strong>'
maxlength_js_enforce: false
field_heading_level:
type: options_select
weight: 10
region: content
settings: { }
third_party_settings: { }
field_instructions:
type: markup
weight: 0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ dependencies:
config:
- block_content.type.cta_banner
- field.field.block_content.cta_banner.field_heading
- field.field.block_content.cta_banner.field_heading_level
- field.field.block_content.cta_banner.field_instructions
- field.field.block_content.cta_banner.field_link
- field.field.block_content.cta_banner.field_media
Expand All @@ -27,6 +28,13 @@ content:
third_party_settings: { }
weight: 1
region: content
field_heading_level:
type: list_key
label: hidden
settings: { }
third_party_settings: { }
weight: 6
region: content
field_link:
type: link_separate
label: hidden
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ dependencies:
config:
- block_content.type.grand_hero
- field.field.block_content.grand_hero.field_heading
- field.field.block_content.grand_hero.field_heading_level
- field.field.block_content.grand_hero.field_instructions
- field.field.block_content.grand_hero.field_link
- field.field.block_content.grand_hero.field_media
Expand All @@ -27,6 +28,13 @@ content:
third_party_settings: { }
weight: 1
region: content
field_heading_level:
type: list_key
label: hidden
settings: { }
third_party_settings: { }
weight: 6
region: content
field_link:
type: link_separate
label: hidden
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
uuid: c4cb4f27-4116-41c1-bf7e-3be014652c3a
langcode: en
status: true
dependencies:
config:
- block_content.type.cta_banner
- field.storage.block_content.field_heading_level
module:
- options
id: block_content.cta_banner.field_heading_level
field_name: field_heading_level
entity_type: block_content
bundle: cta_banner
label: 'Heading Level'
description: 'Optionally override heading level for this banner'
required: true
translatable: false
default_value:
-
value: '2'
default_value_callback: ''
settings: { }
field_type: list_string
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
uuid: 7b19e30a-e34c-4869-8522-0ec9074beca3
langcode: en
status: true
dependencies:
config:
- block_content.type.grand_hero
- field.storage.block_content.field_heading_level
module:
- options
id: block_content.grand_hero.field_heading_level
field_name: field_heading_level
entity_type: block_content
bundle: grand_hero
label: 'Heading Level'
description: 'Optionally override heading level for this banner'
required: true
translatable: true
default_value:
-
value: '2'
default_value_callback: ''
settings: { }
field_type: list_string
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
uuid: 55bae3c6-a2a3-4e10-85ac-63cc9eefc787
langcode: en
status: true
dependencies:
module:
- block_content
- options
id: block_content.field_heading_level
field_name: field_heading_level
entity_type: block_content
type: list_string
settings:
allowed_values:
-
value: '1'
label: H1
-
value: '2'
label: H2
allowed_values_function: ''
module: options
locked: false
cardinality: 1
translatable: true
indexes: { }
persist_with_no_fields: false
custom_storage: false
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,6 @@
* @todo Possibly move these styles into admin theme.
*/

/* set variables */
.layout-builder-configure-block {
--color-border: var(--wool);
--color-border-lightest: var(--color-basic-white);
--color-link-hover: hsl(210, 100%, 21%);
--color-link-border: #187e9b;
--color-background-primary: var(--color-basic-white);
--color-background-hover: var(--dark-theme-gray);
--color-border-hover: var(--darkest-gray);
--color-text-lighter: #2D424D;
--color-text-primary: var(--color-gray-800);
}


/* General styles */
.views-basic--params {
display: none;
Expand Down Expand Up @@ -61,22 +47,26 @@
}

/* base for labels */
.glb-form-type--radio label {
.glb-form-type--radio label.glb-form-item__label.glb-option {
display: flex !important;
align-items: center;
flex-direction: column;
gap: 1rem;
flex: 1 auto;
padding: var(--size-spacing-6) var(--size-spacing-4);
border-radius: 0.25rem;
border: 2px solid var(--color-border);
border: 2px solid var(--wool);
aspect-ratio: 2/1;
display: block !important;
text-align: left;
background: var(--dark-theme-gray);
border: 2px solid var(--color-border);
background-color: var(--dark-theme-gray);
padding: var(--size-spacing-4) var(--size-spacing-5);
color: var(--color-text-primary);
color: var(--darkest-gray);
border-radius: 0.25rem;
margin-bottom: var(--size-spacing-4);
}

.glb-form-type--radio label.glb-form-item__label.glb-option:hover {
border-color: var(--darkest-gray);
}


/******
/******** Input styles
Expand Down Expand Up @@ -223,15 +213,15 @@
.layout-builder-configure-block .form-item-settings-block-form-group-user-selection-entity-and-view-mode-entity-types:focus label,
.layout-builder-configure-block .form-item-settings-block-form-group-user-selection-entity-and-view-mode-view-mode:hover label,
.layout-builder-configure-block .form-item-settings-block-form-group-user-selection-entity-and-view-mode-view-mode:focus label {
background-color: var(--color-background-hover);
border-color: var(--color-border-hover);
background-color: var(--dark-theme-gray);
border-color: var(--darkest-gray);
}

.layout-builder-configure-block .glb-form-type--radio input[checked="checked"] + label,
.layout-builder-configure-block .glb-form-type--radio input[checked="checked"] + label:hover,
.layout-builder-configure-block .glb-form-type--radio:hover input[checked="checked"] + label {
background-color: var(--color-text-primary);
color: var(--color-background-primary) !important;
background-color: var(--darkest-gray);
color: var(--wool) !important;
}


Expand All @@ -247,8 +237,8 @@
}

.form-item-settings-block-form-group-user-selection-entity-and-view-mode-entity-types input[value="post"][checked="checked"] + label {
background-color: var(--color-text-primary);
color: var(--color-background-primary);
background-color: var(--darkest-gray);
color: var(--wool);
}


Expand All @@ -260,8 +250,8 @@
}

.form-item-settings-block-form-group-user-selection-entity-and-view-mode-entity-types input[value="event"][checked="checked"] + label {
background-color: var(--color-text-primary);
color: var(--color-background-primary);
background-color: var(--darkest-gray);
color: var(--wool);
}

/* Pages */
Expand All @@ -272,8 +262,8 @@
}

.form-item-settings-block-form-group-user-selection-entity-and-view-mode-entity-types input[value="page"][checked="checked"] + label {
background-color: var(--color-text-primary);
color: var(--color-background-primary);
background-color: var(--darkest-gray);
color: var(--wool);
}

/* Profiles */
Expand All @@ -284,8 +274,8 @@
}

.form-item-settings-block-form-group-user-selection-entity-and-view-mode-entity-types input[value="profile"][checked="checked"] + label {
background-color: var(--color-text-primary);
color: var(--color-background-primary);
background-color: var(--darkest-gray);
color: var(--wool);
}

/*
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@
const radioGroups = [
'input[name="settings[block_form][group_user_selection][entity_and_view_mode][entity_types]"]',
'input[name="settings[block_form][group_user_selection][entity_and_view_mode][view_mode]"]',
'input[name="settings[block_form][group_user_selection][filter_and_sort][term_operator]"]',
'input[name="settings[block_form][group_user_selection][filter_options][term_operator]"',
'input[name="settings[block_form][group_user_selection][filter_and_sort][term_operator]"',
'input[name="settings[block_form][group_user_selection][entity_specific][event_time_period]"]'
];

// Apply the function to each radio input group
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,11 @@ public function formElement(

$form['group_user_selection']['entity_specific'] = [
'#type' => 'container',
'#attributes' => [
'class' => [
'grouped-items',
],
],
];

$form['group_user_selection']['options'] = [
Expand Down Expand Up @@ -274,9 +279,9 @@ public function formElement(
'#type' => 'radios',
'#title' => $this->t('Event Time Period'),
'#options' => [
'future' => $this->t('Future Events'),
'past' => $this->t('Past Events'),
'all' => $this->t('All Events'),
'future' => $this->t('Future Events') . '<img src="/profiles/custom/yalesites_profile/modules/custom/ys_views_basic/assets/icons/event-time-future.svg" alt="Future Events icon showing a calendar with a future-pointing arrow to the right.">',
'past' => $this->t('Past Events') . '<img src="/profiles/custom/yalesites_profile/modules/custom/ys_views_basic/assets/icons/event-time-past.svg" alt="Past Events icon showing a calendar with a past-pointing arrow to the left.">',
'all' => $this->t('All Events') . '<img src="/profiles/custom/yalesites_profile/modules/custom/ys_views_basic/assets/icons/event-time-all.svg" alt="All Events icon showing a calendar.">',
],
'#default_value' => ($items[$delta]->params) ? $this->viewsBasicManager->getDefaultParamValue('event_time_period', $items[$delta]->params) : 'future',
'#states' => [
Expand Down