YALB-1428: Bug: Action Banner Field Labels

[dblanken-yale]

YALB-1428: Bug: Action Banner Field Labels

Description of work

• Rename CTA Banner Heading label to Action Banner Heading
• Rename CTA Banner Content label to Action Banner Content
• Rename Link heading for the link widget to Call-to-action

Functional testing steps:

• Attempt to add an action banner to a page
• Verify that the form displays the renamed labels for the fields (No CTA should be present in the labels)
• Verify that the overall heading of the Link section is now Call-to-action

[dblanken-yale]

Again, created this with don't merge until the node access fix can be pulled in.

[github-actions]

Created multidev environment pr-402 for yalesites-platform.

[github-actions]

Created multidev environment pr-402 for yalesites-platform.

[codechefmarc]

This works as described. However, I wanted to point out that this is also changing the "link text" to "Call-to-action text" on other components too - Grand Hero and Content Spotlight were the ones I checked. If this is cool, then that's fine. But, if not, we may want to get more specific (if we can?) to target just the Action Banner.

[dblanken-yale]

Boo! I checked some that had links and they didn’t change but it did seem odd that it didn’t given my code. Thanks for checking. I’ll see what I can do to distinguish.

[miketullo95]

this looks great! 👍

[miketullo95]

oh i just saw the note on distinguishing, if its going to be a lot of custom code to do so, I would say keeping the "call to action" link label but reverting the changes to the specific link text as "call to action text" since its effecting other components
@dblanken-yale

[dblanken-yale]

@miketullo95 Ah ok. Well, let me bring it up in stand up today to see if there's something I'm missing, but if no one knows, maybe that can be a ticket for later? I am able to use a hook to get the block type, and I am able to use a hook to get the label, but I'm having trouble being able to retrieve both in order to ONLY change the action banner version. :(

[dblanken-yale]

@codechefmarc @miketullo95 I think I was able to finally target it with hook_field_widget_complete_form_alter. If you two wouldn't mind giving it another check, I'd appreciate it. It should now only target cta_banner items.

[dblanken-yale]

Well, when it's done building that is. :D

[miketullo95]

it works! amazing job

[codechefmarc]

Yup, also tested on other components and site settings, etc, and it only shows on the action banner. Nice hook find - I wasn't aware of that one. Approved!