Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YALB-1057: Add automatic smartquotes #392

Merged
merged 3 commits into from
Sep 17, 2023
Merged

YALB-1057: Add automatic smartquotes #392

merged 3 commits into from
Sep 17, 2023

Conversation

nJim
Copy link
Contributor

@nJim nJim commented Aug 18, 2023

YALB-1057: Add automatic smartquotes

Description of work

  • Adds automatic smartquotes to WYSIWYG fields.
  • This leverage the Typogrify module to automatically apply text formats.
  • Note: this does not work for non-WYSIWYG fields such as page titles.

Functional testing steps:

  • Login to the multidev using CAS login
  • Navigate to a node's layout builder interface
  • Test the 'Text' block
    • Edit a 'text' area. In the WYISWYG area, put quotes around a word or phrase. Use the quotes on your keyboard. Notice that these are straight quotes in CKEditor.
    • Save this change. Verify that the rendered block has replaced these quotes with curly quotes.
    • You can also test that two hyphens are concerted to an n-dash and three hyphens an m-dash.
  • Please repeat the smartquote test with the following updated blocks and fields:
    • Text fields: Image Block (caption field). Quick Links Block (content field), Wrapped Image Block , Custom Card (text field.)
    • Heading fields for the following blocks: Custom cards, directory, event list, post list, quick links

@github-actions
Copy link

Visit Site

Created multidev environment pr-392 for yalesites-platform.

@nJim nJim self-assigned this Aug 28, 2023
@nJim nJim changed the title YALB-1057: Allow smartquotes YALB-1057: Add automatic smartquotes Sep 2, 2023
@codechefmarc codechefmarc self-requested a review September 8, 2023 16:05
Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the following with results:

  • Text: works
  • Image caption: doesn't work
    Screenshot 2023-09-08 at 9 06 51 AM
  • Quick links, both content and heading: doesn't work
    Screenshot 2023-09-08 at 9 07 28 AM
  • Wrapped image: content works, image caption doesn't
    Screenshot 2023-09-08 at 9 08 40 AM
  • Custom cards: Component title, card title, and content don't work
    Screenshot 2023-09-08 at 9 10 40 AM
  • Directory, Events List, Post List heading: Doesn't work
    Screenshot 2023-09-08 at 9 11 28 AM

I'm wondering if there is something else processing the text for some of these that is getting in the way?

@nJim nJim merged commit b4aaa0a into develop Sep 17, 2023
0 of 2 checks passed
@nJim nJim deleted the YALB-1057-quotes branch September 17, 2023 02:33
@nJim nJim mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants