Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yalb-mega-footer-2): remove two footer logos from mega footer, ch… #290

Merged
merged 9 commits into from
Sep 19, 2023

Conversation

joetower
Copy link
Contributor

@joetower joetower commented Sep 11, 2023

YALB-1510: Mega Menu: Present Level One links as Headings - BE

YALB-1487: Mega Footer Branding: FE

Description of work

  • Refines mega footer responsiveness
  • Changes the logo group to 2 logos instead of 4
  • Moves the placement of social links to render directly under the link group links instead of rendering in a grid row consisting of equal spacing properties (to the link group) which had more spacing, previously.

Testing Link(s)

Functional Review Steps

yalb-mega-footer-2-storybook-responsiveness.mp4

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for dev-component-library-twig ready!

Name Link
🔨 Latest commit a08c28c
🔍 Latest deploy log https://app.netlify.com/sites/dev-component-library-twig/deploys/6504d5ad70c0370008d170e2
😎 Deploy Preview https://deploy-preview-290--dev-component-library-twig.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joetower joetower self-assigned this Sep 12, 2023
@joetower joetower marked this pull request as ready for review September 13, 2023 18:43
Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works fine in storybook. Great job!

@joetower
Copy link
Contributor Author

@dblanken-yale @codechefmarc

I met with Franz today to discuss the placement of the social links in the mega footer. Could one of you please confirm you see the following, when testing responsiveness?

https://pr-419-yalesites-platform.pantheonsite.io/welcome

Notes:

  • Social Links are always aligned to the end/right-side of the screen
  • At desktop and tablet sizes, the social links are at the top of the secondary region of the footer
  • At small/mobile sizes, the social links are at the bottom of the secondary region.

After these changes are given a look I think this will be good to go for Monday release @codechefmarc

yalb-mega-footer-2-social-links.mp4

Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I see the change. I do like the horizontal line that separates it now! Approved.

@joetower joetower marked this pull request as draft September 18, 2023 21:38
@joetower joetower marked this pull request as ready for review September 18, 2023 21:38
@joetower joetower merged commit be5e1cc into develop Sep 19, 2023
6 checks passed
@joetower joetower deleted the YALB-mega-footer-2 branch September 19, 2023 18:17
@nJim nJim mentioned this pull request Sep 21, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants