-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(yalb-mega-footer-2): remove two footer logos from mega footer, ch… #290
Conversation
…ange social to flex
✅ Deploy Preview for dev-component-library-twig ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and works fine in storybook. Great job!
I met with Franz today to discuss the placement of the social links in the mega footer. Could one of you please confirm you see the following, when testing responsiveness? https://pr-419-yalesites-platform.pantheonsite.io/welcome Notes:
After these changes are given a look I think this will be good to go for Monday release @codechefmarc yalb-mega-footer-2-social-links.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I see the change. I do like the horizontal line that separates it now! Approved.
🎉 This PR is included in version 1.36.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
YALB-1510: Mega Menu: Present Level One links as Headings - BE
YALB-1487: Mega Footer Branding: FE
Description of work
Testing Link(s)
Functional Review Steps
yalb-mega-footer-2-storybook-responsiveness.mp4