Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pip editable install + optimization_level=0 sims #75

Merged
merged 2 commits into from
Dec 25, 2021
Merged

pip editable install + optimization_level=0 sims #75

merged 2 commits into from
Dec 25, 2021

Conversation

Phionx
Copy link
Member

@Phionx Phionx commented Dec 25, 2021

Closes #59 and #62 .

@Phionx Phionx requested a review from amirebrahimi December 25, 2021 02:58
@Phionx Phionx added this to the 0.2.0 milestone Dec 25, 2021
amirebrahimi
amirebrahimi approved these changes Dec 25, 2021
View reviewed changes
Copy link
Collaborator

@amirebrahimi amirebrahimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't review the diffs of the Jupyter notebooks, so I'll assume they are good.
All the rest LGTM!

README.md Show resolved Hide resolved
@Phionx Phionx merged commit 5f85ac7 into master Dec 25, 2021
@Phionx Phionx deleted the feature/59/sims-pip branch December 25, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirebrahimi amirebrahimi amirebrahimi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

[pip] add dev pip extra, update README and notebooks
2 participants
@Phionx @amirebrahimi