Fixed tests to handle zero matching in OTP 27 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for the patch! Could you please add the pull request description to the commit message? It is interesting and will be valuable in the Git history. |
Merged
|
I stopped the test against Erlang 23. You can rebase your branch on top of the latest master and CI should be happy. |
Starting from OTP 27, `0.0` no longer matches `-0.0`, so several tests need explicit `-` signs. Also added `+` signs to suppress warnings requiring explicit `+0.0` for matching.
dw-kihara
force-pushed
the
fix/float_zero_match
branch
from
3406ca6 to
cfaafe5
Compare
Added the description. Does it make sence? |
Yes :-) I merged your patch, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from OTP 27,
0.0no longer matches-0.0, so several tests need explicit-signs. Also added+signs to suppress warnings requiring explicit+0.0for matching.