(voxpupuli#236) Enable python module stream on EL8. Bump minimum pupp…

…et version

The certbot package on EL8 currently requires `/usr/bin/python3.6`, which is part of the `python36` module stream, and needs enabled in order to install.

Bump the minimum puppet version to 6.15.0 since the enable_only feature of the dnfmodule provider was added in https://tickets.puppetlabs.com/browse/PUP-10235

REFERENCE.md

@@ -61,6 +61,7 @@ The following parameters are available in the `letsencrypt` class:
 * [`environment`](#environment)
 * [`package_name`](#package_name)
 * [`package_ensure`](#package_ensure)
+* [`dnfmodule_version`](#dnfmodule_version)
 * [`package_command`](#package_command)
 * [`config_file`](#config_file)
 * [`config`](#config)
@@ -116,6 +117,14 @@ The value passed to `ensure` when installing the client with the `package` metho
 
 Default value: `'installed'`
 
+##### <a name="dnfmodule_version"></a>`dnfmodule_version`
+
+Data type: `String`
+
+The yum module stream version to enable on EL8 and greater variants using the `package` method with the `dnfmodule` provider.
+
+Default value: `'python36'`
+
 ##### <a name="package_command"></a>`package_command`
 
 Data type: `String`
@@ -302,6 +311,7 @@ The following parameters are available in the `letsencrypt::install` class:
 * [`configure_epel`](#configure_epel)
 * [`package_ensure`](#package_ensure)
 * [`package_name`](#package_name)
+* [`dnfmodule_version`](#dnfmodule_version)
 
 ##### <a name="configure_epel"></a>`configure_epel`
 
@@ -327,6 +337,14 @@ Name of package to use when installing the client with the `package` method.
 
 Default value: `$letsencrypt::package_name`
 
+##### <a name="dnfmodule_version"></a>`dnfmodule_version`
+
+Data type: `String`
+
+The yum module stream version to enable on EL8 and greater variants using the `package` method with the `dnfmodule` provider.
+
+Default value: `$letsencrypt::dnfmodule_version`
+
 ### <a name="letsencryptplugindns_rfc2136"></a>`letsencrypt::plugin::dns_rfc2136`
 
 This class installs and configures the Let's Encrypt dns-rfc2136 plugin.

manifests/init.pp

@@ -16,6 +16,7 @@
 # @param environment An optional array of environment variables
 # @param package_name Name of package and command to use when installing the client with the `package` method.
 # @param package_ensure The value passed to `ensure` when installing the client with the `package` method.
+# @param dnfmodule_version The yum module stream version to enable on EL8 and greater variants using the `package` method with the `dnfmodule` provider.
 # @param package_command Path or name for letsencrypt executable when installing the client with the `package` method.
 # @param config_file The path to the configuration file for the letsencrypt cli.
 # @param config A hash representation of the letsencrypt configuration file.
@@ -57,6 +58,7 @@
   Array $environment                     = [],
   String $package_name                   = 'certbot',
   $package_ensure                        = 'installed',
+  String $dnfmodule_version              = 'python36',
   String $package_command                = 'certbot',
   Stdlib::Unixpath $config_dir           = '/etc/letsencrypt',
   String $config_file                    = "${config_dir}/cli.ini",

manifests/install.pp

@@ -3,12 +3,22 @@
 # @param configure_epel  A feature flag to include the 'epel' class and depend on it for package installation.
 # @param package_ensure The value passed to `ensure` when installing the client with the `package` method.
 # @param package_name Name of package to use when installing the client with the `package` method.
+# @param dnfmodule_version The yum module stream version to enable on EL8 and greater variants using the `package` method with the `dnfmodule` provider.
 #
 class letsencrypt::install (
   Boolean $configure_epel                = $letsencrypt::configure_epel,
   String $package_name                   = $letsencrypt::package_name,
   String $package_ensure                 = $letsencrypt::package_ensure,
+  String $dnfmodule_version              = $letsencrypt::dnfmodule_version,
 ) {
+  if ($facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] >= '8') {
+    package { 'enable python module stream':
+      name        => $dnfmodule_version,
+      enable_only => true,
+      provider    => 'dnfmodule',
+    }
+  }
+
   package { 'letsencrypt':
     ensure => $package_ensure,
     name   => $package_name,

metadata.json

@@ -70,7 +70,7 @@
   "requirements": [
     {
       "name": "puppet",
-      "version_requirement": ">= 6.1.0 < 8.0.0"
+      "version_requirement": ">= 6.15.0 < 8.0.0"
     }
   ],
   "dependencies": [

spec/classes/letsencrypt_install_spec.rb

@@ -7,7 +7,8 @@
       {
         configure_epel: false,
         package_ensure: 'installed',
-        package_name: 'letsencrypt'
+        package_name: 'letsencrypt',
+        dnfmodule_version: 'python36'
       }
     end
     let(:additional_params) { {} }
@@ -42,6 +43,13 @@
             is_expected.to contain_package('letsencrypt').that_requires('Class[epel]')
           end
         end
+
+        case facts[:operatingsystemmajrelease]
+        when '7'
+          it { is_expected.not_to contain_package('enable python module stream').with_name('python36') }
+        when '8'
+          it { is_expected.to contain_package('enable python module stream').with_name('python36').with_enable_only('true').with_provider('dnfmodule') }
+        end
       end
     end
   end