Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to configure the file edit token timeout #40

Closed
oanalavinia opened this issue Jun 29, 2023 · 1 comment · Fixed by #41
Closed

Add option to configure the file edit token timeout #40

oanalavinia opened this issue Jun 29, 2023 · 1 comment · Fixed by #41
Assignees
@oanalavinia
Labels
Priority: Major Type: Improvement
Milestone
1.3

Comments

@oanalavinia
Copy link
Collaborator

oanalavinia commented Jun 29, 2023 •
edited
Loading

Right now, the token that authenticates the Collabora editing has a timeout of 1h. This value is not working for all use cases and most often can lead to major issues, see #37 for a detailed report.

I propose to have a configuration option in order to let administrators decide the token lifetime span.
Also, the best will be to increase the default to a higher value, since 1h is to short for the basic use of this app.
@oanalavinia oanalavinia added this to the 1.3 milestone Jun 29, 2023
@oanalavinia oanalavinia self-assigned this Jun 29, 2023
oanalavinia added a commit to oanalavinia/application-collabora that referenced this issue Jul 10, 2023
@oanalavinia
Add option to configure the file edit token timeout xwikisas#40
95403b8 
* first version, commited to save work, needs refactoring
oanalavinia added a commit to oanalavinia/application-collabora that referenced this issue Jul 14, 2023
@oanalavinia
Add option to configure the file edit token timeout xwikisas#40
263993a 
* refactor code
* moved token timeout value on the token, in order to cache it
* update parameter description
@oanalavinia oanalavinia linked a pull request Jul 14, 2023 that will close this issue
Add option to configure the file edit token timeout #40 #41
Merged
oanalavinia added a commit that referenced this issue Jul 14, 2023
@oanalavinia
Add option to configure the file edit token timeout #40 (#41)
90e6c8e 
* moved token timeout value on the token, in order to cache it
* update parameter description
@oanalavinia
Copy link
Collaborator Author

I created a configuration option for token timeout, which will have a default value of 5 (hours)

@oanalavinia oanalavinia mentioned this issue Jul 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanalavinia oanalavinia

Labels
Priority: Major Type: Improvement
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

Add option to configure the file edit token timeout #40 oanalavinia/application-collabora
1 participant
@oanalavinia