Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to save the edited file after leaving the collabora editor open for a longer period of time #37

Open
lucaa opened this issue Jun 29, 2023 · 2 comments
Assignees
Labels
Priority: Major Type: Bug Something isn't working

Comments

@lucaa
Copy link

lucaa commented Jun 29, 2023

How to reproduce:

  • open the editor for a file
  • make some changes, save them with the save button from the Collabora editor
  • make some more changes
  • leave the editor open in a tab for some time
    • apparently, according to the code, it shouldn't matter what happens in the editor during this time: additional changes can be made, or no action, or even additional saves could happen
  • click the "save" button from the Collabora editor

Expected result:

  • the file is saved with the latest changes

Actual result:

  • an error is displayed about an invalid token and the file cannot be saved (example in french):
    image
  • if the "close" button is used at this point to close the editor, all changes are lost and there is no warning about closing with unsaved changes.
@lucaa lucaa added Type: Bug Something isn't working Priority: Major labels Jun 29, 2023
@oanalavinia oanalavinia self-assigned this Jun 29, 2023
@lucaa
Copy link
Author

lucaa commented Jun 29, 2023

See the workaround from #36 (comment) for not losing the work that was done on the file in the collabora editor.

@oanalavinia oanalavinia changed the title Impossible to save the edited file after leaving the collabora editor open for ~1h Impossible to save the edited file after leaving the collabora editor open for a longer period of time Jul 27, 2023
@oanalavinia
Copy link
Collaborator

oanalavinia commented Jul 27, 2023

NOTE that this issue was updated to not specify for how long you need to leave the editor open before you hit the problem. This was needed since after implementing #40, the default timeout value was moved to 5 hours, instead of 1. This value can be modified by administration.

I am not sure if now this isn't actually the expected behavior, to have a timeout for how long you can have an editor open.
My proposal as solution is to still have the possibility to renew the current editing session without hitting refresh. Maybe add some sort of a renew token button in the UI, which will do this silently at the user request. (maybe check #36 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Major Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants