Add functional tests #16 #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Created the test modules and structures
* Fixed functional test errors regarding the server initialization * Created AdminToolsViewPage class to access the info from the WebHome * Refactored the server identification code to fix a bug where the incorect server is detected * Adapted the tests
* Added functional tests for WebHome * Added functional tests for modals * Modified code to correct errors found using functional tests
* Fixed licensing compatibility issues
|
Currently having an issue with the following test at line 112. The issue is that the application is not seen in the Applications panel, but I'm not sure what causes it. I'm thinking it may be a missing dependency, but I did not identify what may be missing. Error log: https://up1.xwikisas.com/#GN9TRHXpO49fjt0odyRZsw EDIT: I removed this testing part and created a new issue #37 for solving the application panel issue. |
mflorea
requested changes
Dec 7, 2023
...ools-default/src/main/java/com/xwiki/admintools/internal/data/identifiers/CurrentServer.java
Outdated
Show resolved
Hide resolved
...s-default/src/main/java/com/xwiki/admintools/internal/data/identifiers/TomcatIdentifier.java
Outdated
Show resolved
Hide resolved
...s-default/src/main/java/com/xwiki/admintools/internal/data/identifiers/TomcatIdentifier.java
Outdated
Show resolved
Hide resolved
application-admintools-default/src/main/resources/templates/configurationTemplate.vm
Outdated
Show resolved
Hide resolved
application-admintools-default/src/main/resources/templates/configurationTemplate.vm
Outdated
Show resolved
Hide resolved
application-admintools-ui/src/main/resources/AdminTools/WebHome.xml
Outdated
Show resolved
Hide resolved
...pplication-admintools-test-docker/src/test/it/com/xwiki/admintools/test/ui/AdminToolsIT.java
Outdated
Show resolved
Hide resolved
...pplication-admintools-test-docker/src/test/it/com/xwiki/admintools/test/ui/AdminToolsIT.java
Outdated
Show resolved
Hide resolved
...pplication-admintools-test-docker/src/test/it/com/xwiki/admintools/test/ui/AdminToolsIT.java
Outdated
Show resolved
Hide resolved
Comment on lines
+154
to
+155
| switchToNewTab(testUtils, mainWindowHandle); | ||
| testUtils.getDriver().switchTo().window(mainWindowHandle); |
There was a problem hiding this comment.
I need to manually switch tabs to verify the opened content, as Selenium does not change focus when a tab is opened. I had a comment explaining this but did not offer a lot of details.
* Modified comments * Split AdminToolsViewPage in different classes specialized in different dashboard sections * Modified Page object selectors * Added test execution condition * Modifed page objects functions and interaction
* Modified comments * Modified execution condition * Removed test for application panel as it is currently not working (will create a separate issue to address this) * Code refactoring
* Merged main branch * Added test for application pannel
# Conflicts: # application-admintools-default/src/main/resources/templates/configurationTemplate.vm # application-admintools-default/src/main/resources/templates/filesSectionTemplate.vm # application-admintools-default/src/main/resources/templates/securityTemplate.vm # application-admintools-default/src/test/java/com/xwiki/admintools/internal/data/ConfigurationDataProviderTest.java # application-admintools-ui/src/main/resources/AdminTools/Code/Translations.xml
* modified tests * modified translations
# Conflicts: # application-admintools-default/src/main/resources/templates/configurationTemplate.vm # application-admintools-ui/src/main/resources/AdminTools/Code/Translations.xml
# Conflicts: # application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/ConfigurationDataProvider.java # application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/identifiers/CurrentServer.java # application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/identifiers/TomcatInfo.java # application-admintools-default/src/test/java/com/xwiki/admintools/internal/data/ConfigurationDataProviderTest.java # application-admintools-default/src/test/java/com/xwiki/admintools/internal/data/identifiers/CurrentServerTest.java
* Solved merge conflicts
# Conflicts: # application-admintools-default/src/main/resources/templates/configurationTemplate.vm # application-admintools-default/src/main/resources/templates/filesSectionTemplate.vm
# Conflicts: # application-admintools-default/src/main/resources/templates/configurationTemplate.vm # application-admintools-default/src/main/resources/templates/filesSectionTemplate.vm
* Solved merge issues
# Conflicts: # application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/identifiers/CurrentServer.java # application-admintools-default/src/main/resources/templates/configurationTemplate.vm # application-admintools-default/src/main/resources/templates/filesSectionTemplate.vm # application-admintools-default/src/test/java/com/xwiki/admintools/internal/data/ConfigurationDataProviderTest.java # application-admintools-default/src/test/java/com/xwiki/admintools/internal/data/identifiers/CurrentServerTest.java # application-admintools-default/src/test/java/com/xwiki/admintools/internal/data/identifiers/TomcatInfoTest.java
* removed unnecessary code * code refactoring
# Conflicts: # application-admintools-ui/src/main/resources/AdminTools/Code/Translations.xml
* fixed merge
# Conflicts: # application-admintools-default/src/main/java/com/xwiki/admintools/internal/AdminToolsEventListener.java
* added tests for health check section * started tests for instance usage section
* added tests for instance usage section * added comments * updated test poms version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create functional tests for Admin Tools