fix UnusedConstructorParams

xuwei-k · Oct 30, 2024 · 6a317ca · 6a317ca
1 parent 93fa995
commit 6a317ca
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/input/src/main/scala-3/fix/UnusedConstructorParamsTest2.scala b/input/src/main/scala-3/fix/UnusedConstructorParamsTest2.scala
@@ -0,0 +1,6 @@
+/*
+rule = UnusedConstructorParams
+ */
+package fix
+
+class A6(val x: Int)(using x2: String)
diff --git a/input/src/main/scala/fix/UnusedConstructorParamsTest.scala b/input/src/main/scala/fix/UnusedConstructorParamsTest.scala
@@ -10,3 +10,5 @@ class A2(x: Int) // assert: UnusedConstructorParams
 class A3(`type`: Int) extends A1(`type`)
 
 class A4(var x: Int)
+
+class A5(val x: Int)(implicit x2: String)
diff --git a/rules/src/main/scala/fix/UnusedConstructorParams.scala b/rules/src/main/scala/fix/UnusedConstructorParams.scala
@@ -21,6 +21,7 @@ class UnusedConstructorParams extends SyntacticRule("UnusedConstructorParams") {
       case x: Defn.Class if !x.mods.exists(_.is[Mod.Case]) =>
         val params = x.ctor.paramClauses.flatten
           .filterNot(_.mods.exists(_.is[Mod.Implicit]))
+          .filterNot(_.mods.exists(_.is[Mod.Using]))
           .filterNot(_.mods.exists(_.is[Mod.VarParam]))
           .filterNot(_.mods.exists(_.is[Mod.ValParam]))
         val allTokens = {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -10,3 +10,5 @@ class A2(x: Int) // assert: UnusedConstructorParams
		class A3(`type`: Int) extends A1(`type`)

		class A4(var x: Int)

		class A5(val x: Int)(implicit x2: String)