Remove uint casts in string.(Try)CopyTo

xtqqczze · Oct 7, 2024 · f8f7f2d · f8f7f2d · xtqqczze · Oct 7, 2024
1 parent 48dbc4f
commit f8f7f2d
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/src/libraries/System.Private.CoreLib/src/System/String.cs b/src/libraries/System.Private.CoreLib/src/System/String.cs
@@ -432,14 +432,12 @@ public unsafe void CopyTo(int sourceIndex, char[] destination, int destinationIn
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public void CopyTo(Span<char> destination)
         {
-            if ((uint)Length <= (uint)destination.Length)
-            {
-                Buffer.Memmove(ref destination._reference, ref _firstChar, (uint)Length);
-            }
-            else
+            if (destination.Length < Length)
             {
                 ThrowHelper.ThrowArgumentException_DestinationTooShort();
             }
+
+            Buffer.Memmove(ref destination._reference, ref _firstChar, (uint)Length);
         }
 
         /// <summary>Copies the contents of this string into the destination span.</summary>
@@ -448,13 +446,13 @@ public void CopyTo(Span<char> destination)
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public bool TryCopyTo(Span<char> destination)
         {
-            bool retVal = false;
-            if ((uint)Length <= (uint)destination.Length)
+            if (destination.Length < Length)
             {
-                Buffer.Memmove(ref destination._reference, ref _firstChar, (uint)Length);
-                retVal = true;
+                return false;
             }
-            return retVal;
+
+            Buffer.Memmove(ref destination._reference, ref _firstChar, (uint)Length);
+            return true;
         }
 
         // Returns the entire string as an array of characters.