trilinos failure (whith hypre?) on oneapi2023-1-0

[balay]

xr_l_i23-xsdk-100-linux-oneapi2023-1-0

https://gitlab.com/xsdk-project/spack-xsdk/-/jobs/5292585772

icpx: warning: overriding '-march=cascadelake' option with '-march=skylake-avx512' [-Woverriding-t-option]
In file included from /data/xsdkci/VS1mJQ1K/2/xsdk-project/spack-xsdk/spack-stage/balay/spack-stage-trilinos-14.4.0-6criucvgnxhllqmb7jkzh5up4vc3c2mb/spack-src/packages/ifpack2/src/Ifpack2_Hypre.cpp:58:
/data/xsdkci/VS1mJQ1K/2/xsdk-project/spack-xsdk/spack-stage/balay/spack-stage-trilinos-14.4.0-6criucvgnxhllqmb7jkzh5up4vc3c2mb/spack-build-6criucv/packages/ifpack2/src/Ifpack2_HypreParameterMap.hpp:280:1: error: expected expression
const std::map<std::string, double_func> FunctionParameter::hypreMapDoubleFunc_ = {
^
/data/xsdkci/VS1mJQ1K/2/xsdk-project/spack-xsdk/spack-stage/balay/spack-stage-trilinos-14.4.0-6criucvgnxhllqmb7jkzh5up4vc3c2mb/spack-src/packages/ifpack2/src/Ifpack2_Hypre.cpp:76:2: error: expected ';' after top level declarator
}
 ^
 ;
/data/xsdkci/VS1mJQ1K/2/xsdk-project/spack-xsdk/spack-stage/balay/spack-stage-trilinos-14.4.0-6criucvgnxhllqmb7jkzh5up4vc3c2mb/spack-src/packages/ifpack2/src/Ifpack2_Hypre.cpp:78:49: error: expected '}'
#endif // HAVE_IFPACK2_HYPRE && HAVE_IFPACK2_MPI
                                                ^

spack-build-out.txt

This build was successful yesterday - so I'm not sure what change triggered this failure

https://gitlab.com/xsdk-project/spack-xsdk/-/jobs/5291324284

cc: @cgcgcg @lucbv @victorapm

[balay]

A restart of this job goes through

https://gitlab.com/xsdk-project/spack-xsdk/-/jobs/5293426182

And I think I've seen such failure with trilinos builds before [where a restart gets the build going]

perhaps 'make -j' is sometimes build sources in the wrong order - due to some missing dependency? [hence this error?]

[cgcgcg]

The Hypre headers are parsed at configure time by a script in Ifpack2. My best guess is that something goes wrong there. Is there any way that you could send me packages/ifpack2/src/Ifpack2_Hypre.cpp from the build tree the next time this happens? Maybe add it temporarily to the build artifacts?

[balay]

Ok - added Ifpack2_Hypre.cpp to artifacts. Will see if this failure comes up again.

[balay]

The build failed again in CI

https://gitlab.com/xsdk-project/spack-xsdk/-/jobs/5340015481

Ifpack2_Hypre.cpp.txt

[cgcgcg]

Ah, shoot. I totally gave you the wrong file name :-(
Ifpack2_HypreParameterMap.hpp is what we want.
At the same time, it looks like this time it wasn't the Ifpack2 interface that bugged out but the Ifpack one.
So we also want
packages/ifpack/src/Ifpack_HypreParameterMap.h.

[balay]

The issue came up again. https://gitlab.com/xsdk-project/spack-xsdk/-/jobs/5512162488

Ifpack_HypreParameterMap.h.txt
Ifpack2_HypreParameterMap.hpp.txt

[cgcgcg]

Perfect! I think I know what's going on now.

[cgcgcg]

Should be fixed by trilinos/Trilinos#12518