Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trilinos build failure on Frontier with +rocm #241

Open
balos1 opened this issue Oct 19, 2023 · 8 comments
Open

Trilinos build failure on Frontier with +rocm #241

balos1 opened this issue Oct 19, 2023 · 8 comments

Comments

@balos1
Copy link
Member

balos1 commented Oct 19, 2023

The spack output file is too big for github, so here it is on Google drive spack-build-out.txt

@balos1
Copy link
Member Author

balos1 commented Oct 20, 2023

It seems issue is related to the Ifpack interface to Hypre

n file included from /tmp/balos1/spack-stage/spack-stage-trilinos-14.4.0-l5k3rhfwmx4poriyak2aevhkbk626x7r/spack-build-l5k3rhf/packages/stokhos/src/Ifpack2_Hypre_MP_Vector_16_Serial.cpp:51:
/tmp/balos1/spack-stage/spack-stage-trilinos-14.4.0-l5k3rhfwmx4poriyak2aevhkbk626x7r/spack-src/packages/ifpack2/src/Ifpack2_Hypre_def.hpp:480:19: error: no matching function for call to 'HYPRE_IJVectorSetValues'
  IFPACK2_CHK_ERR(HYPRE_IJVectorSetValues(xHypre_,NumEntries,indices,xPtr));
                  ^~~~~~~~~~~~~~~~~~~~~~~
/tmp/balos1/spack-stage/spack-stage-trilinos-14.4.0-l5k3rhfwmx4poriyak2aevhkbk626x7r/spack-build-l5k3rhf/packages/stokhos/src/Ifpack2_Hypre_MP_Vector_16_Serial.cpp:55:44: note: in instantiation of member function 'Ifpack2::Hypre<Tpetra::RowMatrix<Sacado::MP::Vector<Stokhos::StaticFixedStorage<int, double, 16, Kokkos::Serial>>, int, int, Tpetra::KokkosCompat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace>>>::SetCoordinates' requested here
INSTANTIATE_TPETRA_MP_VECTOR_WRAPPER_NODES(IFPACK2_HYPRE_INSTANT)

@jwillenbring
Copy link
Member

@cgcgcg Here is an issue on Frontier.

@cgcgcg
Copy link

cgcgcg commented Oct 25, 2023

@balos1 Do you still have the build directory? Can you get us the file packages/ifpack2/Ifpack2_HypreParameterMap.hpp that gets generated during CMake configure?

@balos1
Copy link
Member Author

balos1 commented Oct 25, 2023

@cgcgcg

Attached.

Ifpack2_HypreParameterMap.hpp.txt

@cgcgcg
Copy link

cgcgcg commented Oct 25, 2023

Ah shoot, this isn't one of the automatically wrapped Hypre functions. I think what's happening here is that Stokhos is enabled but Hypre cannot support AD types. So we'd need some logic in Ifpack2 that disables the Hypre adapter.

@balay
Copy link
Member

balay commented Nov 9, 2023

Looks like a duplicate of #238

@cgcgcg
Copy link

cgcgcg commented Nov 9, 2023

Unfortunately it is not. I'm working on a fix.

@cgcgcg
Copy link

cgcgcg commented Nov 16, 2023

Should be fixed by trilinos/Trilinos#12518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants