Merge pull request #116 from bdovaz/feature/reuse-serializer-instance

Allow reuse of Serializer instance
xoofx · Aug 11, 2022 · 1fa7fa2 · 1fa7fa2
2 parents a8fcaa5 + 3fc9219
commit 1fa7fa2
Show file tree

Hide file tree

Showing 4 changed files with 70 additions and 3 deletions.
diff --git a/src/SharpYaml.Tests/Serialization/SerializationTests2.cs b/src/SharpYaml.Tests/Serialization/SerializationTests2.cs
@@ -47,10 +47,8 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.ComponentModel;
-using System.Globalization;
 using System.IO;
 using System.Linq;
-using System.Runtime.CompilerServices;
 using NUnit.Framework;
 using SharpYaml.Serialization;
 using SharpYaml.Serialization.Serializers;
@@ -160,6 +158,53 @@ public void TestSimpleStructWithDefaultValues()
             Assert.AreEqual(value.Test.Height, newValue.Test.Height);
         }
 
+        private static readonly object[] s_serializerSettingsReuseFail =
+        {
+            new object[] { new SerializerSettings { } },
+            new object[] { new SerializerSettings { EmitAlias = true, ResetAlias = false } }
+        };
+
+        [TestCaseSource(nameof(s_serializerSettingsReuseFail))]
+        public void TestSerializerReuseFail(SerializerSettings serializerSettings)
+        {
+            var serializer = new Serializer(serializerSettings);
+
+            object data = new
+            {
+                Value = "testValue"
+            };
+
+            var text = serializer.Serialize(data);
+            serializer.Deserialize(text);
+
+            text = serializer.Serialize(data);
+            Assert.Throws<AnchorNotFoundException>(() => serializer.Deserialize(text));
+        }
+
+        private static readonly object[] s_serializerSettingsReuseSuccess =
+        {
+            new object[] { new SerializerSettings { EmitAlias = true, ResetAlias = true } },
+            new object[] { new SerializerSettings { EmitAlias = false, ResetAlias = true } },
+            new object[] { new SerializerSettings { EmitAlias = false, ResetAlias = false } }
+        };
+
+        [TestCaseSource(nameof(s_serializerSettingsReuseSuccess))]
+        public void TestSerializerReuseSuccess(SerializerSettings serializerSettings)
+        {
+            var serializer = new Serializer(serializerSettings);
+
+            object data = new
+            {
+                Value = "testValue"
+            };
+
+            var text = serializer.Serialize(data);
+            serializer.Deserialize(text);
+
+            text = serializer.Serialize(data);
+            Assert.DoesNotThrow(() => serializer.Deserialize(text));
+        }
+
         [Test]
         public void TestSimpleStructMemberOrdering()
         {

diff --git a/src/SharpYaml/Serialization/Serializer.cs b/src/SharpYaml/Serialization/Serializer.cs
@@ -223,6 +223,11 @@ public void Serialize(IEmitter emitter, object? graph, Type? type, SerializerCon
             context.WriteYaml(graph, type);
             context.Writer.DocumentEnd();
             context.Writer.StreamEnd();
+
+            if (Settings.ResetAlias && ObjectSerializer is AnchorSerializer anchorSerializer)
+            {
+                anchorSerializer.Reset();
+            }
         }
 
         /// <summary>
@@ -535,6 +540,11 @@ public void Serialize(IEmitter emitter, object? graph, Type? type, SerializerCon
                 reader.Expect<StreamEnd>();
             }
 
+            if (Settings.ResetAlias && ObjectSerializer is AnchorSerializer anchorSerializer)
+            {
+                anchorSerializer.Reset();
+            }
+
             return result;
         }
 

diff --git a/src/SharpYaml/Serialization/SerializerSettings.cs b/src/SharpYaml/Serialization/SerializerSettings.cs
@@ -83,6 +83,7 @@ public SerializerSettings(IYamlSchema? schema)
             PreferredIndent = 2;
             IndentLess = false;
             EmitAlias = true;
+            ResetAlias = false;
             SortKeyForMapping = true;
             EmitJsonCompatible = false;
             EmitCapacityForList = false;
@@ -129,6 +130,12 @@ public int PreferredIndent
         /// <value><c>true</c> to emit anchor alias; otherwise, <c>false</c>.</value>
         public bool EmitAlias { get; set; }
 
+        /// <summary>
+        /// Gets or sets a value indicating whether to reset anchor alias in order to reuse <see cref="Serializer" /> instance. Default is false.
+        /// </summary>
+        /// <value><c>true</c> to reset anchor alias; otherwise, <c>false</c>.</value>
+        public bool ResetAlias { get; set; }
+
         /// <summary>
         /// Gets or sets a value indicating whether to emit tags when serializing. Default is false.
         /// </summary>

diff --git a/src/SharpYaml/Serialization/Serializers/AnchorSerializer.cs b/src/SharpYaml/Serialization/Serializers/AnchorSerializer.cs
@@ -46,7 +46,6 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
-using System.Globalization;
 using System.Reflection;
 using SharpYaml.Events;
 
@@ -143,5 +142,11 @@ public override void WriteYaml(ref ObjectContext objectContext)
 
             base.WriteYaml(ref objectContext);
         }
+
+        public void Reset()
+        {
+            aliasToObject.Clear();
+            objectToAlias.Clear();
+        }
     }
 }