Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X2-6273 added smart breakdown item wrapping #246

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

SemenStruchev
Copy link
Contributor

No description provided.

Copy link
Contributor

@KarthickXola KarthickXola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some lint warnings on unused vars

Comment on lines 44 to 54
<td colSpan={2} className="break-all text-left leading-none">
<span className="mr-0.5">{methodIcon}</span>
<span>{children}</span>
<span className="ml-1 text-sm">
{info && (
<span className="mr-2 rounded bg-white p-1 uppercase text-black empty:hidden">{info}</span>
)}
{secondary && <span className="empty:hidden">{secondary}</span>}
</span>
<td colSpan={2} className="text-left leading-none">
<div className="flex flex-wrap items-center leading-3.5">
<span className="break-word">
<span className="mr-0.5">{methodIcon}</span>
{children}
</span>
<span className="ml-1 text-sm">
{info && (
<span className="mr-2 ml-1 rounded bg-white p-1 uppercase leading-6 text-black empty:hidden">
{info}
</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold on merging this PR as it will cause conflicts with #309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants