-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X2-6273 added smart breakdown item wrapping #246
Open
SemenStruchev
wants to merge
15
commits into
xola:master
Choose a base branch
from
SemenStruchev:X2-6273
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarthickXola
suggested changes
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some lint warnings on unused vars
manojx031
approved these changes
Jul 24, 2023
SemenStruchev
force-pushed
the
X2-6273
branch
from
January 14, 2024 15:33
155a864
to
b9a97eb
Compare
rushi
requested changes
Feb 26, 2024
src/components/Breakdown.jsx
Outdated
Comment on lines
44
to
54
<td colSpan={2} className="break-all text-left leading-none"> | ||
<span className="mr-0.5">{methodIcon}</span> | ||
<span>{children}</span> | ||
<span className="ml-1 text-sm"> | ||
{info && ( | ||
<span className="mr-2 rounded bg-white p-1 uppercase text-black empty:hidden">{info}</span> | ||
)} | ||
{secondary && <span className="empty:hidden">{secondary}</span>} | ||
</span> | ||
<td colSpan={2} className="text-left leading-none"> | ||
<div className="flex flex-wrap items-center leading-3.5"> | ||
<span className="break-word"> | ||
<span className="mr-0.5">{methodIcon}</span> | ||
{children} | ||
</span> | ||
<span className="ml-1 text-sm"> | ||
{info && ( | ||
<span className="mr-2 ml-1 rounded bg-white p-1 uppercase leading-6 text-black empty:hidden"> | ||
{info} | ||
</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please hold on merging this PR as it will cause conflicts with #309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.