#167 Allow classnames for switch #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushi
commented
Aug 21, 2022
| // TODO: Native checkbox input `checked` and `disabled` properties are not prefixed with `is`. | ||
| // Decide on the naming convention. | ||
| export const Switch = ({ isChecked = false, size = "medium", ...rest }) => { | ||
| export const Switch = ({ isChecked = false, size = "medium", classNames = { parent: "", inner: "" }, ...rest }) => { |
There was a problem hiding this comment.
parent and inner match what we 8 lines about in sizes
There was a problem hiding this comment.
How about container and input (or switch)? That is what we used for some other components
rushi
commented
Aug 21, 2022
| isChecked ? sizes[size].translate : "translate-x-0", | ||
| "ui-switch-inner pointer-events-none inline-block transform rounded-full bg-white shadow ring-0 transition duration-200 ease-in-out", |
rushi
commented
Aug 21, 2022
Comment on lines
-33
to
+31
| "relative inline-flex flex-shrink-0 cursor-pointer rounded-full border-2 border-transparent transition-colors duration-200 ease-in-out focus:outline-none", | ||
| "relative inline-flex flex-shrink-0 cursor-pointer rounded-full border-2 border-transparent", |
nemanjakrstic
suggested changes
Sep 10, 2023
| @@ -49,6 +51,7 @@ export const Switch = ({ isChecked = false, size = "medium", ...rest }) => { | |||
| Switch.propTypes = { | |||
| isChecked: PropTypes.bool, | |||
| size: PropTypes.string, | |||
| classNames: PropTypes.shape({ switch: PropTypes.string, content: PropTypes.string }), | |||
There was a problem hiding this comment.
Does not match the props
| // TODO: Native checkbox input `checked` and `disabled` properties are not prefixed with `is`. | ||
| // Decide on the naming convention. | ||
| export const Switch = ({ isChecked = false, size = "medium", ...rest }) => { | ||
| export const Switch = ({ isChecked = false, size = "medium", classNames = { parent: "", inner: "" }, ...rest }) => { |
There was a problem hiding this comment.
How about container and input (or switch)? That is what we used for some other components
rushi
force-pushed
the
customize-switch
branch
from
b1cdf38 to
1ee994e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.