Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the bridge installationId based #548

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

nplasterer
Copy link
Contributor

Adds the ability to test history sync by having multiple installations with the same inboxId running at the same time.

In React Native we keep a map of clients by inboxId in the bridge so that you can easily fetch a client and call it's respective functions on it. This makes it so you can only have one client at a time. Unfortunately when it comes to installations we want a client per installation the two options are to

This changes our client mapping to be by installationId

@nplasterer nplasterer self-assigned this Nov 26, 2024
@nplasterer nplasterer requested a review from a team as a code owner November 26, 2024 17:43
@nplasterer nplasterer changed the base branch from main to np/consent-streaming November 26, 2024 17:44
@nplasterer
Copy link
Contributor Author

All tests are green!

Copy link

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates and tests all looking good 👍

@nplasterer nplasterer merged commit c2b3228 into np/consent-streaming Nov 26, 2024
2 of 3 checks passed
@nplasterer nplasterer deleted the np/installation-id-based branch November 26, 2024 20:15
Copy link
Contributor

🎉 This PR is included in version 3.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants