Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3 Performance Improvements #522

Merged
merged 11 commits into from
Nov 4, 2024
Merged

V3 Performance Improvements #522

merged 11 commits into from
Nov 4, 2024

Conversation

nplasterer
Copy link
Contributor

Remove members and creatorInboxId from the listing of groups because it will never be performant.

Also upgrades to the version of peerInboxId that is more performant.

Android still is a good bit slower.

Here is

iOS

Metric V2Alix V3Davon
50 DMs (1st load) 116 ms 275 ms
50 DMs (2nd load) 25 ms 9 ms
55 DMs (1st load) 19 ms 34 ms
55 DMs (2nd load) 9 ms 9 ms

Android

Metric V2Alix V3Davon
50 DMs (1st load) 364 ms 538 ms
50 DMs (2nd load) 55 ms 62 ms
55 DMs (1st load) 56 ms 61 ms
55 DMs (2nd load) 25 ms 62 ms

@nplasterer nplasterer self-assigned this Nov 2, 2024
@nplasterer nplasterer requested a review from a team as a code owner November 2, 2024 23:53
@nplasterer nplasterer merged commit 971ea61 into main Nov 4, 2024
4 of 5 checks passed
@nplasterer nplasterer deleted the np/performance-inbox-id branch November 4, 2024 17:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

🎉 This PR is included in version 2.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrisch alexrisch alexrisch approved these changes

Assignees

@nplasterer nplasterer

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nplasterer @alexrisch