-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added thirdweb ConnectWallet button to LaunchScreen #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronvoell
force-pushed
the
cameronvoell/example-wallet-auth
branch
from
December 21, 2023 22:15
417a130
to
f64420f
Compare
cameronvoell
force-pushed
the
cameronvoell/example-wallet-auth
branch
2 times, most recently
from
December 22, 2023 19:02
6a81e07
to
a11f243
Compare
cameronvoell
force-pushed
the
cameronvoell/example-wallet-auth
branch
from
January 9, 2024 19:19
a11f243
to
c00864f
Compare
cameronvoell
force-pushed
the
cameronvoell/example-wallet-auth
branch
from
January 18, 2024 23:40
caec6ed
to
fc0d7a5
Compare
nplasterer
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
🎉 This PR is included in version 1.24.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159
Description
This PR adds the ability to connect with accounts from wallet apps via the Thirdweb SDK. The only wallets that were consistently working for me were Rainbow and Metamask so those are the only two options for now.
To Do before removing PR draft state:
example/.env
for reading thirdweb API keyexample/README.md
Testing Steps:
example/README.md
steps for obtaining a Thirdweb client id (not mandatory, just clears network errors from SDK when it tries to obtain visual assets)Log in flow with Metamask or Rainbow via Thirdweb SDK
Note onnpm install --legacy-peer-deps
and @thirdweb-dev/react-nativeexpo
dependency versionAs mentioned in the linked issue, re-adding the dependency for
@thirdweb-dev/react-native
means that we need to always runnpm install --force
when installing dependencies in the example directory (README.md already includes these instructions). The reason is that@thirdweb-dev/react-native
specifies a version for expo dependency that is less than our current version. I left a comment on the thirdweb sdk repo to see if updating this dependency has blockers for any reason => thirdweb-dev/js#1778 (comment)No longer relevant, as thirdweb is compatible with our version of expo now.