Use locally generated protos and Node image #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
force-pushed
the
02-28-Use_locally_generated_protos
branch
6 times, most recently
from
cf743ce to
ce81b05
Compare
neekolas
force-pushed
the
02-28-Use_locally_generated_protos
branch
from
ce81b05 to
47481e5
Compare
This was referenced Feb 29, 2024
nplasterer
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
xmtp/protoThe size of this looks intimidating mostly because we are now committing the generated proto code into this repo, instead of having it live in
xmtp/proto