-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open/close instead of stream:stream #117
base: master
Are you sure you want to change the base?
Conversation
Latest draft, stanza.io
Ok, I've update the readme. Is this enough, or do you want more? |
Can this be merged? This would make node-xmpp-bosh work with the letast versions of stanza.io and latest HEAD of strophe.js (I want to make a new strophe.js release when this is merged) without workarounds. |
Yes, a merge would be cool 👍 |
It's possible not break compatibility with old stream:stream client? |
@camaran No, the new protocol is not backwards-compatible. The only thing you could do is implement both protocols, try the current one and if authentication fails try the deprecated protocol. Ideally we should just drop the deprecated protocol altogether though, all servers support the current protocol by now, node-xmpp-bosh is one of the last XMPP Servers/Proxies that still uses the deprecated protocol. |
@Gordin for example Jappix client not support the new protocol |
@camaran Someone should file a bug with Jappix then, the old protocol is deprecated since February 2014 now… (Plus the changes on the client side are really not that big, they're just not compatible) |
This change makes it compatible with latest draft (in fact, this has been there since revison 01), where
<stream:stream>
and</stream:stream>
has been replaced with<open/>
and<close/>
.This makes it work with latest stanza.io, but probably breaks clients still relying on old
<stream:stream>
method.