Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include platform.h in vanilla.cpp #216

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Include platform.h in vanilla.cpp #216

merged 2 commits into from
Jul 30, 2024

Conversation

ACascarino
Copy link
Contributor

Part of VFH-149

@ACascarino ACascarino added size:S Small issue or pull request status:ready for review Please review labels Jul 30, 2024
@ACascarino ACascarino requested a review from xhuw July 30, 2024 14:34
xhuw
xhuw reviewed Jul 30, 2024
View reviewed changes
Copy link

@xhuw xhuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good, but I think it should be mentioned in the changelog that this fix is for 15.3

@mbanth mbanth assigned ACascarino and unassigned mbanth Jul 30, 2024
@ACascarino ACascarino requested a review from xhuw July 30, 2024 14:50
@ACascarino ACascarino merged commit 936aca4 into xmos:develop Jul 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhuw xhuw xhuw approved these changes

Assignees

@ACascarino ACascarino

Labels
size:S Small issue or pull request status:ready for review Please review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ACascarino @xhuw @mbanth