Prepare release v3.5.1 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix test_i2s_basic_slave and test_slave_bclk_invert tests
Fix test_i2s_basic_master and test_basic_master_external_clock
…ted the acceptable backpressure thresholds accordingly
Modify backpressure test to something sensible
Fixes for release v3.5.1
mbanth
requested changes
Aug 1, 2024
| @@ -150,8 +147,9 @@ i2s_restart_t i2s_restart_check(void *app_data) | |||
| i2s_restart_t restart; | |||
|
|
|||
| frames_sent++; | |||
| if (frames_sent == 4) | |||
| if (frames_sent == 4) { | |||
There was a problem hiding this comment.
Opening a new scope is a good idea. It would be good to open a new scope in the else clause as well.
Merged
mbanth
approved these changes
Aug 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE: Updated lib_mic_array to v5.3.0