Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify backpressure test to something sensible #105

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

shuchitak
Copy link
Contributor

@shuchitak shuchitak commented Feb 21, 2024

https://xmosjira.atlassian.net/browse/AP-420

The backpressure test made no sense to me, so I've tried to modify it to atleast test something. I ran the test and logged the callback functions' delay values at which the backpressure breaks the LRCLK timing and used these values as the test pass threshold. This way, if there's ever a change in the library that reduces the allowed backpressure from the callback functions, we'd be able to catch that (once the CI runs are fixed!).
Also, for 768KHz, even a delay of 0 was breaking the LR timing so I removed 768KHz from the list of sample rates we tested.

The test in its current form passes consistently on my Mac.

pytest lib_i2s/test_backpressure.py -s

@mbanth mbanth assigned shuchitak and unassigned mbanth Feb 21, 2024
@shuchitak shuchitak requested a review from ACascarino February 21, 2024 14:22
Copy link
Contributor

@ACascarino ACascarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hitting request changes so I can be notified when the work is done - as discussed, would be good if this test could actually guarantee some level of operation i.e. writing to and reading from memory within the callback

…ted the acceptable backpressure thresholds accordingly
@shuchitak shuchitak merged commit 94a1dca into xmos:develop Mar 7, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants