Fix test_i2s_basic_master and test_basic_master_external_clock #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuchitak
changed the title
ACascarino
approved these changes
Feb 19, 2024
| @@ -21,7 +21,7 @@ def uncollect_if(bitdepth, num_in, num_out): | |||
| if bitdepth == 16 and num_in == 4 and num_out == 4: | |||
| return True | |||
|
|
|||
| @pytest.mark.uncollect_if(func=uncollect_if) | |||
| #@pytest.mark.uncollect_if(func=uncollect_if) | |||
There was a problem hiding this comment.
You may wish to consider removing this mark and the uncollect_if function altogether if we no longer need to skip these tests
| @@ -16,6 +16,9 @@ set(APP_LINK_OPTIONS | |||
| -target=XCORE-AI-EXPLORER | |||
| ) | |||
|
|
|||
| # Compile main.c which contains the i2s_callback_group_t functions in O3 mode | |||
There was a problem hiding this comment.
Yeah same comment as last time - would be good to be able to put actual numbers on "how many ticks can I actually use in the callbacks", since it's obviously lower than we thought it was
There was a problem hiding this comment.
I'm going to look at the back pressure test next. Hopefully it does that.
Yes! Passing consistently on my Mac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://xmosjira.atlassian.net/browse/AP-403
Changes in this PR:
pytest lib_i2s/test_i2s_basic_master.py
pytest lib_i2s/test_basic_master_external_clock.py
pytest lib_i2s/test_i2s_basic_master.py --nightly
pytest lib_i2s/test_basic_master_external_clock.py --nightly
Note that the mclk frequency is set such that the mclk_bclk_ratio is atleast 2 for the worst case (192KHz). I could not get the test to pass reliably if testing with mclk_bclk_ratio set to 1. Sometimes, the bclk clock block would start with a falling edge instead of a rising edge, causing the LR clk to start before the bclk.
With mclk_bclk_ratio of 2 or more, I couldn't recreate this issue.