[WIP] Skeleton for building VStatefulSet controller #9
Conversation
codyjrivera
changed the title
| @@ -24,7 +25,8 @@ if [ "$registry" != "remote" ] && [ "$registry" != "local" ]; then | |||
| exit 2 | |||
| fi | |||
|
|
|||
| if cd deploy/$1 && kubectl apply -f crd.yaml && kubectl apply -f rbac.yaml && kubectl apply -f deploy_$registry.yaml; then | |||
| ## use imperative management for CRDs since metadata for PodTemplateSpec is too long. | |||
| if cd deploy/$1 && kubectl create -f crd.yaml && kubectl apply -f rbac.yaml && kubectl apply -f deploy_$registry.yaml; then | |||
There was a problem hiding this comment.
@codyjrivera just curious, why use create rather than apply here?
There was a problem hiding this comment.
The template: PodTemplateSpec field of the VStatefulSet spec makes the resulting CRD file too large to work with the declarative kubectl apply. I admit that using the imperative kubectl create is a cheap workaround. Is there a better way of doing this?
deploy/vstatefulset/crd.yaml
Outdated
There was a problem hiding this comment.
@codyjrivera can you change vstatefulset to v_stateful_set?
There was a problem hiding this comment.
Yes. I will update the naming to be consistent with this scheme.
deploy.sh
Outdated
| @@ -14,7 +14,8 @@ NC='\033[0m' | |||
| app=$1 | |||
| registry=$2 | |||
|
|
|||
| if [ "$app" != "zookeeper" ] && [ "$app" != "rabbitmq" ] && [ "$app" != "fluent" ]; then | |||
| if [ "$app" != "zookeeper" ] && [ "$app" != "rabbitmq" ] && [ "$app" != "fluent" ]\ | |||
| && [ "$app" != "vstatefulset" ]; then | |||
There was a problem hiding this comment.
Can you change vstatefulset to v_stateful_set?
There was a problem hiding this comment.
Can you change vstatefulset/vstatefulset.yaml to v_stateful_set/v_stateful_set.yaml?
src/vstatefulset_controller.rs
Outdated
There was a problem hiding this comment.
similarly, can you change this to v_stateful_set_controller.rs?
Signed-off-by: Xudong Sun <[email protected]>
Signed-off-by: Xudong Sun <[email protected]>
Remove some TLA proof rules that are redundant. Also, make some other proof rules private, as they don't need to be exposed to users. --------- Signed-off-by: Xudong Sun <[email protected]>
The prototype replica set controller implements the basic scaling up/down functionality. It lists all the pods in the same namespace, filters out the pods that do not match the replica set object's selector, and them create/delete pods to make sure there are `replicas` number of matched pods. The replica set controller is not verified yet, and there are still more features to implement, such as claiming orphan pods. --------- Signed-off-by: Xudong Sun <[email protected]>
The code is written by @utaal . The goal is to build a macro that takes the exec controller code and outputs its spec version that can be directly used in the proof, so that we do not have to write the controller model each time. Signed-off-by: Xudong Sun <[email protected]>
Signed-off-by: Xudong Sun <[email protected]>
codyjrivera
force-pushed
the
cody/add-vstatefulset
branch
from
8f71989 to
36d1f00
Compare
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
codyjrivera
force-pushed
the
cody/add-vstatefulset
branch
from
36d1f00 to
0661874
Compare
|
Stale pull request |
No description provided.